Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>I see a few problems:</p> <ul> <li><p>You will probably want to handle HttpUnhandledException in your error handler. This is what most of the exceptions raised by your page will be.</p></li> <li><p>I don't see the value of a handle and resume (PostHandlingAction = None) policy where you call Server.ClearError(). Basically your page has thrown an exception and you are doing nothing. Best case scenario, the user sees an empty page. Worst case, you could have a partially rendered page with no indication what happened.</p></li> <li><p>I also don't see the point of potentially throwing an exception from your error handler. You're either going to end up with the yellow screen of death or your going to force another error page to be called (e.g. a customErrors redirect defined in web.config).</p></li> <li><p><del>Your HandleException logic does not account for the NotifyRethrow scenario.</del> <em>(Removed based on comment that there is a customError redirect)</em>.</p></li> </ul> <p>Using <a href="https://stackoverflow.com/questions/1751052/using-enterprise-library-exception-handling-application-block-in-asp-net-code-r#1751971">@vladhorby's ErrorPage</a> and keeping your main logic would give something like this:</p> <pre><code>protected void Application_Error() { Exception error = Server.GetLastError(); if (error is HttpUnhandledException) { error = error.InnerException; } Exception errorToThrow; if (ExceptionPolicy.HandleException(error, "Application Error", out errorToThrow)) { Response.Redirect(string.Format("ErrorPage.aspx?Message={0}", Uri.EscapeDataString((errorToThrow ?? error).Message))); } else { Server.ClearError(); } } </code></pre> <p><br> A few notes about the above code:</p> <ul> <li><p>If ErrorPage.aspx throws an Exception for some reason you could end up in an infinite loop so make sure that ErrorPage.aspx has it's own Page_Error to try to avoid unhandled exceptions propagating to the global error handler.</p></li> <li><p>It does not take into account objections 2 and 3. :)</p></li> </ul> <p>I'm not sure about your situation and requirements but have you considered using <a href="http://dotnetslackers.com/articles/aspnet/ErrorLoggingModulesAndHandlers.aspx" rel="nofollow noreferrer">ELMAH</a>?</p>
    singulars
    1. This table or related slice is empty.
    1. POUsing Enterprise Library Exception Handling Application Block in ASP.NET - Code Review
      singulars
      1. PTQuestion
    1. PTAnswer
    1. USCommunity
    1. USRandy Levy
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. POUsing Enterprise Library Exception Handling Application Block in ASP.NET - Code Review
      singulars
      1. PTQuestion
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTAcceptedByOriginator
    3. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    1. COMy response, in an "iron sharpening iron" sort of way: 1) I like the point about HttpUnhandledException. I'll include that check. 2) I also don't see the value in a PostHandlingAction = None policy for the reasons you mentioned, but I would defer that issue to the policy rather than here. 3) Per my answer to vladhorby, I failed to specify that I have customErrors configured to redirect based on the HTTP status code of the resulting error, whether the original or rethrown error. 4) I believe that rethrowing the exception does account for the notifyRethrow scenario. Am I missing something?
      singulars
      1. PO
      1. USJohn Bledsoe
    2. COPoint 3 is subjective -- I prefer to keep everything together. For point 4...ok I see...you are using a customError tag to handle unhandled exceptions from your handler and letting the NotifyRethrow with no handler just bubble up to that handler. :)
      singulars
      1. PO
      1. USRandy Levy
    3. CO+1 for your first final note, I accidentally introduced that bug into a site before and couldn't figure out why firefox kept telling me my page would redirect infinitely.
      singulars
      1. PO
      1. USChris Marisic
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload