StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

POKernel Panic after changes in sys_close
primarykey
Id
1725152
data
AcceptedAnswerId
0
AnswerCount
2
ClosedDate
CommentCount
1
CommunityOwnedDate
CreationDate
2009-11-12T20:30:53.860
FavoriteCount
0
LastActivityDate
2009-11-22T00:27:28.273
LastEditDate
LastEditorUserId
0
OwnerUserId
90261
ParentId
0
PostTypeId
1
Score
0
ViewCount
892
LastEditorDisplayName
text
Body
I'm doing a course on operating systems and we work in Linux Red Hat 8.0 AS part of an assignment I had to change sys close and sys open. Changes to sys close passed without an incident, but when I introduce the changes to sys close suddenly the OS encounters an error during booting, claiming it cannot mount root fs, and invokes panic. EIP is reportedly at sys close when this happens. Here are the changes I made (look for the "HW1 additions" comment): In fs/open.c: <pre><code>asmlinkage long sys_open(const char * filename, int flags, int mode) { char * tmp; int fd, error; event_t* new_event; #if BITS_PER_LONG != 32 flags |= O_LARGEFILE; #endif tmp = getname(filename); fd = PTR_ERR(tmp); if (!IS_ERR(tmp)) { fd = get_unused_fd(); if (fd >= 0) { struct file *f = filp_open(tmp, flags, mode); error = PTR_ERR(f); if (IS_ERR(f)) goto out_error; fd_install(fd, f); } /* HW1 additions */ if (current->record_flag==1){ new_event=(event_t*)kmalloc(sizeof(event_t), GFP_KERNEL); if (!new_event){ new_event->type=Open; strcpy(new_event->filename, tmp); file_queue_add(*new_event, current->queue); } } /* End HW1 additions */ out: putname(tmp); } return fd; out_error: put_unused_fd(fd); fd = error; goto out; } asmlinkage long sys_close(unsigned int fd) { struct file * filp; struct files_struct *files = current->files; event_t* new_event; char* tmp = files->fd[fd]->f_dentry->d_name.name; write_lock(&files->file_lock); if (fd >= files->max_fds) goto out_unlock; filp = files->fd[fd]; if (!filp) goto out_unlock; files->fd[fd] = NULL; FD_CLR(fd, files->close_on_exec); __put_unused_fd(files, fd); write_unlock(&files->file_lock); /* HW1 additions */ if(current->record_flag == 1){ new_event=(event_t*)kmalloc(sizeof(event_t), GFP_KERNEL); if (!new_event){ new_event->type=Close; strcpy(new_event->filename, tmp); file_queue_add(*new_event, current->queue); } } /* End HW1 additions */ return filp_close(filp, files); out_unlock: write_unlock(&files->file_lock); return -EBADF; } </code></pre> The task_struct defined in schedule.h was changed at the end to include: <pre><code>unsigned int record_flag; /* when zero: do not record. when one: record. */ file_queue* queue; </code></pre> And file queue as well as event t are defined in a separate file as follows: <pre><code>typedef enum {Open, Close} EventType; typedef struct event_t{ EventType type; char filename[256]; }event_t; typedef struct file_quque_t{ event_t queue[101]; int head, tail; }file_queue; </code></pre> file queue add works like this: <pre><code>void file_queue_add(event_t event, file_queue* queue){ queue->queue[queue->head]=event; queue->head = (queue->head+1) % 101; if (queue->head==queue->tail){ queue->tail=(queue->tail+1) % 101; } } </code></pre>
Tags
<linux><linux-kernel><panic>
Title
Kernel Panic after changes in sys_close
singulars
PostAcceptedAnswerId
1. This table or related slice is empty.
PostParentId
1. This table or related slice is empty.
PostTypePostTypeId
1. PTQuestion
UserLastEditorUserId
1. This table or related slice is empty.
UserOwnerUserId
1. USEpsilon Vector
plurals
PostLinksPostIdRelatedPostId
1. This table or related slice is empty.
PostLinksRelatedPostIdPostId
1. This table or related slice is empty.
PostsAcceptedAnswerId
1. This table or related slice is empty.
PostsParentIdCreationDate
1. PO
 singulars
 PostTypePostTypeId
 PTAnswer
2. PO
 singulars
 PostTypePostTypeId
 PTAnswer
VotesPostIdCreationDate
1. This table or related slice is empty.
CommentsPostId
1. COCan you put stack dump that you get when system panics?
 singulars
 PostPostId
 POKernel Panic after changes in sys_close
 UserUserId
 USvinit dhatrak

Querying!

Guidance

A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.