Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>There is a lot wrong here, so I'll try and explain each section separately.</p> <p>First, the test for lowercase (testing <code>01100000b</code>) isn't going to work. It'll never be zero, for either case, since they both have the 6th bit set.</p> <p>If think the only way to make sure you're only uppercasing 'a' to 'z' is to explicitly compare for characters in that range. So your first test becomes something like this:</p> <pre><code> cmp al,'a' jl noChange cmp al,'z' jle toUpperCase noChange: mov [edi],al ... </code></pre> <p>Then the additional <code>test al,01000000b</code> you had before <code>mov [edi],al</code> does nothing, so that can be removed.</p> <p>And once you've copied the character in the branch that is already uppercase, you should be jumping to the top of the loop, otherwise you're going to fall through to the <code>toUpperCase</code> branch and store the character a second time.</p> <p>Also you should be incrementing edi, otherwise you're going to write to the same position over and over again.</p> <pre><code> mov [edi],al inc edi ; You need to add this inc esi jmp getNext ; You need to add this </code></pre> <p>Same thing goes for the <code>toUpperCase</code> branch. You need to increment edi, and again you have a test there that does nothing.</p> <pre><code>toUpperCase: AND al,11011111b mov [edi],al inc edi ; Add this inc esi jmp getNext </code></pre> <p>Finally, when exiting, you need to add a NULL to the end of the outStr. And there is no need to assign edi back to outStr, especially since it is now pointing to the end of the string.</p> <pre><code>exitProc: mov [edi],0 </code></pre> <p>Now this could be made more efficient, in that you have a lot of repeated code as well. But that is all that <em>has</em> to be done to get it working.</p>
    singulars
    1. This table or related slice is empty.
    1. POConverting lowercase character string to uppercase masm
      singulars
      1. PTQuestion
    1. PTAnswer
    1. USJames Holderness
    1. USJames Holderness
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. POConverting lowercase character string to uppercase masm
      singulars
      1. PTQuestion
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTAcceptedByOriginator
    2. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    1. COI just realised you need to ignore special characters as well which this code currently doesn't do.
      singulars
      1. PO
      1. USJames Holderness
    2. COOk, I have made the changes you have suggested, and thank you for explaining them. However, the string that is being inputted is "The 32 [thirty two] red Foxes {(#$&%)"... and it goes on, but my output for some reason stops at THE
      singulars
      1. PO
      1. UStmaxxcar
    3. COCould that be why it won't go past the first word?
      singulars
      1. PO
      1. UStmaxxcar
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload