Databases
StackOverflow2013
Postsdbo
POSimple, general-interest, code-analyzers based, Java questions
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POSimple, general-interest, code-analyzers based, Java questions
    primarykey
    data
    text
    <p>OK, after reviewing some code with <a href="http://pmd.sourceforge.net" rel="nofollow noreferrer"> PMD</a> and <a href="http://findbugs.sourceforge.net/" rel="nofollow noreferrer">FindBugs</a> code analyzers, i was able to do great changes on the reviewed code. However, there are some things i don't know how to fix. I'll iterate them bellow, and (for better reference) i will give each question a number. Feel free to answer to any/all of them. Thanks for your patience.</p> <p>1. Even tough i have removed some of the rules, the associated warnings are still there, after re-evaluate the code. Any idea why?</p> <hr> <p>2. Please look at the declarations : </p> <pre><code> private Combo comboAdress; private ProgressBar pBar; </code></pre> <p>and the references to objects by getters and setters : </p> <pre><code> private final Combo getComboAdress() { return this.comboAdress; } private final void setComboAdress(final Combo comboAdress) { this.comboAdress = comboAdress; } private final ProgressBar getpBar() { return this.pBar; } private final void setpBar(final ProgressBar pBar) { this.pBar = pBar; } </code></pre> <p>Now, i wonder why the first declaration don't give me any warning on PMD, while the second gives me the following warning : </p> <pre><code>Found non-transient, non-static member. Please mark as transient or provide accessors. </code></pre> <p>More details on that warning <a href="http://pmd.sourceforge.net/rules/javabeans.html#BeanMembersShouldSerialize" rel="nofollow noreferrer"> here</a>.</p> <hr> <p>3. Here is another warning, also given by PMD : </p> <pre><code> A method should have only one exit point, and that should be the last statement in the method </code></pre> <p>More details on that warning <a href="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" rel="nofollow noreferrer"> here</a>.</p> <p>Now, i agree with that, but what if i write something like this : </p> <pre><code>public void actionPerformedOnModifyComboLocations() { if (getMainTree().isFocusControl()) { return; } ....//do stuffs, based on the initial test } </code></pre> <p>I tend to agree with the rule, but if performance of the code suggest multiple exit points, what should i do?</p> <hr> <p>4. PMD gives me this :</p> <pre><code>Found 'DD'-anomaly for variable 'start_page' (lines '319'-'322'). </code></pre> <p>when i declare something like : </p> <pre><code>String start_page = null; </code></pre> <p>I get rid of this info (level of warning is info) if i remove the assignment to null, but..i got an error from IDE, saying that the variable could be uninitialized, at some point later in the code. So, i am kind of stuck with that. Supressing the warning is the best you can do?</p> <hr> <p>5. PMD Warning : </p> <pre><code>Assigning an Object to null is a code smell. Consider refactoring. </code></pre> <p>This is the case of a singletone use of GUI components or the case of a method who returns complex objects. Assigning the result to null in the catch() section it's justified by the need to avoid the return of an incomplete/inconsistent object. Yes, NullObject should be used, but there are cases where i don't want to do that. Should i supress that warning then?</p> <hr> <p>6. FindBugs warning #1: </p> <pre><code>Write to static field MyClass.instance from instance method MyClass.handleEvent(Event) </code></pre> <p>in the method </p> <pre><code>@Override public void handleEvent(Event e) { switch (e.type) { case SWT.Dispose: { if (e.widget == getComposite()) { MyClass.instance = null; } break; } } } </code></pre> <p>of the static variable </p> <pre><code>private static MyClass instance = null; </code></pre> <p>The variable allows me to test whether the form is already created and visible or not, and i need to force the re-creation of the form, in some cases. I see no other alternative here. Any insights? (MyClass implements Listener, hence the overrided handleEvent() method).</p> <hr> <p>7. FindBugs warning #2:</p> <pre><code>Class MyClass2 has a circular dependency with other classes </code></pre> <p>This warning is displayed based on simple imports of other classes. Do i need to refactor those imports to make this warning go away? Or the problem relies in MyClass2?</p> <p>OK, enough said for now..expect an update, based on more findings and/or your answers. Thanks.</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. UShypercube
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POSimple, general-interest, code-analyzers based, Java questions
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POSimple, general-interest, code-analyzers based, Java questions
      1. This table or related slice is empty.
      1. VTUpMod
    1. COFindBugs uses class files to do analysis. There is no trace of unused imports for it to find.
      singulars
      1. POSimple, general-interest, code-analyzers based, Java questions
      1. USTom Hawtin - tackline
    2. COI think that statement is correct, since the analysis is performed on bytecode level.
      singulars
      1. POSimple, general-interest, code-analyzers based, Java questions
      1. UShypercube
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload