Databases
StackOverflow2013
Postsdbo
POCustom UITableViewCells are not being reused on UITableView
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POCustom UITableViewCells are not being reused on UITableView
    primarykey
    data
    text
    <p>There seems to be a ton of questions on this but I am not able to use anyone else's answers so was hoping someone could review how I am doing this. I am trying to use. I have two custom UITableViewCells which right now just have a BOOL property on them and thats it in the way of styling.</p> <p>Within my <code>cellForRowAtIndexPath</code> method based on what type of data is coming back I am styling my cells. If the data is a "month" header its a long skinny looking cell and if its a "news item" its going to be a larger white looking cell. </p> <p><img src="https://i.stack.imgur.com/NCh5O.png" alt="enter image description here"> </p> <p>When the table loads everything looks great but if I scroll down to create more cells and then scroll back up the cells are being recreated and eventually scrolling slows down because I am running out of memory.</p> <p>When I set break points the <code>dequeueReusableCellWithIdentifier</code> always returns nil so my cells are never reused which seems to be a problem.</p> <p>In this picture you can see that cells are getting stacked on top of each other and messed up:</p> <p><img src="https://i.stack.imgur.com/nfR2l.png" alt="enter image description here"></p> <p>Here my my code:</p> <pre><code>- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath { static NSString *NewsCellIdentifer = @"NewsCellIdentifier"; static NSString *MonthCellIdentifier = @"MonthCellIdentifier"; NSUInteger row = [indexPath row]; NewsItem *item = [self.newsArray objectAtIndex:row]; if (item.IsMonth == YES) { NewsMonthUITableViewCell *cell = [self.mytableView dequeueReusableCellWithIdentifier:MonthCellIdentifier]; if (cell == nil) { cell = [[NewsMonthUITableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:MonthCellIdentifier]; } // This handles any other "date" cells to allow for different spacing styles. if (item.IsMonth) { UIImageView *av = [[UIImageView alloc] initWithFrame:CGRectMake(0, 10, 400, 20)]; av.backgroundColor = [UIColor clearColor]; av.opaque = NO; av.image = [UIImage imageNamed:@"month-bar-bkgd.png"]; UILabel *monthTextLabel = [[UILabel alloc] initWithFrame:CGRectMake(10, 10, 150, 20)];; CGFloat font = 11.0f; monthTextLabel.font = [BVFont HelveticaNeue:&amp;font]; monthTextLabel.backgroundColor = [UIColor clearColor]; monthTextLabel.font = [BVFont HelveticaNeue:&amp;font]; monthTextLabel.textColor = [BVFont WebGrey]; monthTextLabel.text = item.Title; cell.backgroundColor = [UIColor clearColor]; [cell.contentView addSubview:av]; [cell.contentView addSubview:monthTextLabel]; } return cell; } else { NewsUITableViewCell *cell = [self.mytableView dequeueReusableCellWithIdentifier:NewsCellIdentifer]; if (cell == nil) { cell = [[NewsUITableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:NewsCellIdentifer]; } cell.contentView.backgroundColor = [UIColor clearColor]; UIView *whiteRoundedCornerView = [[UIView alloc] initWithFrame:CGRectMake(10,10,300,100)]; whiteRoundedCornerView.backgroundColor = [UIColor whiteColor]; whiteRoundedCornerView.layer.masksToBounds = NO; whiteRoundedCornerView.layer.cornerRadius = 3.0; whiteRoundedCornerView.layer.shadowOffset = CGSizeMake(-1, 1); whiteRoundedCornerView.layer.shadowOpacity = 0.5; [cell.contentView addSubview:whiteRoundedCornerView]; [cell.contentView sendSubviewToBack:whiteRoundedCornerView]; [cell.contentView addSubview:[self NewsItemThumbnailView:item]]; [cell.contentView addSubview:[self NewsItemTextView:item]]; [cell.contentView addSubview:[self NewsItemCornerIconIndicatorView:item]]; return cell; } return nil; } </code></pre> <p>Thanks for any assistance or advice!</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USFlea
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POCustom UITableViewCells are not being reused on UITableView
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POCustom UITableViewCells are not being reused on UITableView
      1. UStrickster77777
      1. VTFavorite
    3. VO
      singulars
      1. POCustom UITableViewCells are not being reused on UITableView
      1. This table or related slice is empty.
      1. VTUpMod
    1. COare you using storyboard?
      singulars
      1. POCustom UITableViewCells are not being reused on UITableView
      1. USRavindra Bagale
    2. COAre you using Storyboards with dynamic prototypes? If so, check that each cells "Identifier" in the Attributes Inspector is set correctly. Also, if you are NOT using storyboards and dynamic prototypes, your code that creates and adds sub-views should go INSIDE your `if (cell==nil)` block. My advice is to use Storyboards with dynamic prototypes and do the customisation in the cells in IB.
      singulars
      1. POCustom UITableViewCells are not being reused on UITableView
      1. USRobotic Cat
    3. COI am using Storyboard but I am not using Prototyped cells or designing my cells in storyboard. I just have my TableView dropped on the screen but programmatically doing the rest.
      singulars
      1. POCustom UITableViewCells are not being reused on UITableView
      1. USFlea
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload