Databases
StackOverflow2013
Postsdbo
POIs the use of vectors of pointers here unnecessary or worse, cause memory leaks?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POIs the use of vectors of pointers here unnecessary or worse, cause memory leaks?
    primarykey
    data
    text
    <p>I am relatively new to C++ programming, but am a C programmer of 10 years so am more comfortable with pointers to objects than I am with references to objects. </p> <p>I'm writing a Solitaire game - is this design unsafe? Is there a better way?</p> <p>Anyway, I have a class <code>SolitaireGame</code>:</p> <pre><code>class SolitaireGame: { public: SolitaireGame( int numsuits = 1 ); private: Deck * _deck; vector&lt;Card&gt; _shoe; }; </code></pre> <p>The <code>Deck</code> is defined thus:</p> <pre><code>class Deck: { public: Deck::Deck( vector&lt;Card&gt;&amp; shoe ); ~Deck(); int DealsLeft() const { return deals_left; } Card * PullCard(); private: int deals_left; int num_each_deal; deque&lt;Card *&gt; _cards; }; </code></pre> <p>The <code>Deck</code> constructor, takes a reference to a vector of <code>Card</code> objects ( the shoe, normally 104 cards ) and pushes a pointer to each card onto it's own deque of pointers.</p> <pre><code>Deck::Deck( vector&lt;Card&gt;&amp; shoe ) { vector&lt;Card&gt;::iterator iter = shoe.begin(); while( iter != shoe.end() ) { _cards.push_front( &amp;(*iter) ); iter++; } } </code></pre> <p>}</p> <p>The shoe is created in the <code>SolitaireGame</code> constructor. Once this vector of dynamically created <code>Card</code> objects has been created - I then pass a reference to this vector to the constructor.</p> <pre><code>SolitaireGame::SolitaireGame( int numsuits ):_numsuits(numsuits ) { Card * c; vector&lt;Card&gt; _shoe; for( int i = 0; i &lt; NUM_CARDS_IN_SHOE; i++ ) { c = new Card(); _shoe.push_back( *c ); } _deck = new Deck( _shoe ); } </code></pre> <p>My idea was that the shoe would be the container for the actual memory for the <code>Card</code> objects and the <code>Deck</code> and <code>Columns</code> just handle pointers to those <code>Card</code> objects.</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USmacbirdie
    1. USBeeBand
    plurals
    1. This table or related slice is empty.
    1. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POIs the use of vectors of pointers here unnecessary or worse, cause memory leaks?
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POIs the use of vectors of pointers here unnecessary or worse, cause memory leaks?
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POIs the use of vectors of pointers here unnecessary or worse, cause memory leaks?
      1. USvgoklani
      1. VTFavorite
    1. COThanks everyone who pointed out that my `vector<Card> _shoe` variable in the SolitaireGame constructor, shadows the `_shoe` member variable. This is actually a typo, when posting the question ( the code does not contain this variable ). I'm thinking I won't edit it out, so that everyone's answers make sense.
      singulars
      1. POIs the use of vectors of pointers here unnecessary or worse, cause memory leaks?
      1. USBeeBand
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload