StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

PORegexp/perl code for handling both dots and commas as valid decimal separators
primarykey
Id
1487629
data
AcceptedAnswerId
1488933
AnswerCount
5
ClosedDate
CommentCount
6
CommunityOwnedDate
CreationDate
2009-09-28T15:16:39.740
FavoriteCount
1
LastActivityDate
2009-09-30T18:27:26.887
LastEditDate
2009-09-28T15:47:59.913
LastEditorUserId
58394
OwnerUserId
58394
ParentId
0
PostTypeId
1
Score
0
ViewCount
2057
LastEditorDisplayName
text
Body
I'm trying to create a method that provides "best effort" parsing of decimal inputs in cases where I do not know which of these two mutually exclusive ways of writing numbers the end-user is using: <ul> <li>"." as thousands separator and "," as decimal separator</li> <li>"," as thousands separator and "." as decimal separator</li> </ul> The method is implemented as <code>parse_decimal(..)</code> in the code below. Furthermore, I've defined 20 test cases that show how the heuristics of the method should work. While the code below passes the tests it is quite horrible and unreadable. I'm sure there is a more compact and readable way to implement the method. Possibly including smarter use of regexpes. My question is simply: Given the code below and the test-cases, how would you improve parse_decimal(...) to make it more compact and readable while still passing the tests? Clarifications: <ul> <li>Clarification #1: As pointed out in the comments the case <code>^\d{1,3}[\.,]\d{3}$</code> is ambiguous in that one cannot determine logically which character is used as thousands separator and which is used as a decimal separator. In ambiguous cases we'll simply assume that US-style decimals are used: "," as thousands separator and "." as decimal separator.</li> <li>Clarification #2: If you believe that any of test cases is wrong, then please state which of the tests that should be changed and how.</li> </ul> The code in question including the test cases: <pre><code>#!/usr/bin/perl -wT use strict; use warnings; use Test::More tests => 20; ok(&parse_decimal("1,234,567") == 1234567); ok(&parse_decimal("1,234567") == 1.234567); ok(&parse_decimal("1.234.567") == 1234567); ok(&parse_decimal("1.234567") == 1.234567); ok(&parse_decimal("12,345") == 12345); ok(&parse_decimal("12,345,678") == 12345678); ok(&parse_decimal("12,345.67") == 12345.67); ok(&parse_decimal("12,34567") == 12.34567); ok(&parse_decimal("12.34") == 12.34); ok(&parse_decimal("12.345") == 12345); ok(&parse_decimal("12.345,67") == 12345.67); ok(&parse_decimal("12.345.678") == 12345678); ok(&parse_decimal("12.34567") == 12.34567); ok(&parse_decimal("123,4567") == 123.4567); ok(&parse_decimal("123.4567") == 123.4567); ok(&parse_decimal("1234,567") == 1234.567); ok(&parse_decimal("1234.567") == 1234.567); ok(&parse_decimal("12345") == 12345); ok(&parse_decimal("12345,67") == 12345.67); ok(&parse_decimal("1234567") == 1234567); sub parse_decimal($) { my $input = shift; $input =~ s/[^\d,\.]//g; if ($input !~ /[,\.]/) { return &parse_with_separators($input, '.', ','); } elsif ($input =~ /\d,\d+\.\d/) { return &parse_with_separators($input, '.', ','); } elsif ($input =~ /\d\.\d+,\d/) { return &parse_with_separators($input, ',', '.'); } elsif ($input =~ /\d\.\d+\.\d/) { return &parse_with_separators($input, ',', '.'); } elsif ($input =~ /\d,\d+,\d/) { return &parse_with_separators($input, '.', ','); } elsif ($input =~ /\d{4},\d/) { return &parse_with_separators($input, ',', '.'); } elsif ($input =~ /\d{4}\.\d/) { return &parse_with_separators($input, '.', ','); } elsif ($input =~ /\d,\d{3}$/) { return &parse_with_separators($input, '.', ','); } elsif ($input =~ /\d\.\d{3}$/) { return &parse_with_separators($input, ',', '.'); } elsif ($input =~ /\d,\d/) { return &parse_with_separators($input, ',', '.'); } elsif ($input =~ /\d\.\d/) { return &parse_with_separators($input, '.', ','); } else { return &parse_with_separators($input, '.', ','); } } sub parse_with_separators($$$) { my $input = shift; my $decimal_separator = shift; my $thousand_separator = shift; my $output = $input; $output =~ s/\Q${thousand_separator}\E//g; $output =~ s/\Q${decimal_separator}\E/./g; return $output; } </code></pre>
Tags
<regex><perl>
Title
Regexp/perl code for handling both dots and commas as valid decimal separators
singulars
PostAcceptedAnswerId
1. PO
 singulars
 PostTypePostTypeId
 PTAnswer
PostParentId
1. This table or related slice is empty.
PostTypePostTypeId
1. PTQuestion
UserLastEditorUserId
1. USknorv
UserOwnerUserId
1. USknorv
plurals
PostLinksPostIdRelatedPostId
1. This table or related slice is empty.
PostLinksRelatedPostIdPostId
1. This table or related slice is empty.
PostsAcceptedAnswerId
1. This table or related slice is empty.
PostsParentIdCreationDate
1. PO
 singulars
 PostTypePostTypeId
 PTAnswer
2. PO
 singulars
 PostTypePostTypeId
 PTAnswer
3. PO
 singulars
 PostTypePostTypeId
 PTAnswer
VotesPostIdCreationDate
1. VO
 singulars
 PostPostId
 PORegexp/perl code for handling both dots and commas as valid decimal separators
 UserUserId
 USknorv
 VoteTypeVoteTypeId
 VTFavorite
CommentsPostId

Querying!

Guidance

A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.