Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>You have a SOQL in a loop.</p> <pre><code>for (Bids__c bid : recentBids){ String recentProfileName = [SELECT Profile.Name FROM User Where Id = :bid.CreatedById LIMIT 1].Profile.Name; String bidId = profilePrefixMap.get(recentProfileName); bid.Bid_unique_label__c = ((bidId == null) ? defaultPrefix : bidId); } upsert recentBids; </code></pre> <p>This is a performance killer and in fact I'm surprised the limit is 100 queries, used to be no more than 20 queries in a trigger context. A quick fix for your problem would be to use relationship queries with the "dot notation". This will eliminate the need to make the query in a loop.</p> <pre><code>List&lt;Bids__c&gt; recentBids = [SELECT Id, CreatedBy.Profile.Name, Bid_unique_label__c FROM Bids__c WHERE Bid_unique_label__c = NULL]; for (Bids__c bid : recentBids){ String recentProfileName = bid.CreatedBy.Profile.Name; String bidId = profilePrefixMap.get(recentProfileName); bid.Bid_unique_label__c = ((bidId == null) ? defaultPrefix : bidId); } upsert recentBids; </code></pre> <p>This code still has some problems. </p> <ol> <li>You might hit a limit of no more than 10K rows inserted/updated in single transaction (you should at least add LIMIT clause). </li> <li>You're mixing work on data that's in the context of the trigger with data fixes on some unrelated stuff. You shouldn't "piggyback" because users won't understand why they see an error coming from data they didn't touch. </li> <li>Not to mention the fact that "last modified by" is now worthless in your system.</li> </ol> <p>If it's one time activity to clean up your bad data (fix unique labels) - consider running a data fix and removing this code. If it's really a recurring situation - write a batch job. </p> <p>Or investigate if you can write a workflow rule to generate the unique keys, looks like it's be doable and config beats coding a solution.</p>
    singulars
    1. This table or related slice is empty.
    1. POSalesforce: System.LimitException: Too many SOQL queries: 101
      singulars
      1. PTQuestion
    1. PTAnswer
    1. This table or related slice is empty.
    1. USeyescream
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. POSalesforce: System.LimitException: Too many SOQL queries: 101
      singulars
      1. PTQuestion
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    1. COThis solved the error message for now. I will now continue to work with the code.
      singulars
      1. PO
      1. USuser2063927
    2. COGood luck and welcome to StackOverflow :)
      singulars
      1. PO
      1. USeyescream
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload