Databases
StackOverflow2013
Postsdbo
POSorting by column name is not working in plain php on listing page
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POSorting by column name is not working in plain php on listing page
    primarykey
    data
    text
    <p>I have created listing page with pagination and sorting by column name in . Pagination is working fine but search by column name is not working as per expected. Here is my code : </p> <p>index.php</p> <pre><code>&lt;table&gt; &lt;tr&gt; &lt;?php $page = ""; if (isset($_GET['page'])) { $page = "&amp;page=" . $_GET['page'] . ""; } $order = "&amp;order=ASC"; if (isset($_GET['order']) &amp;&amp; $_GET['order'] == "ASC") { $order = "&amp;order=DESC"; } ?&gt; </code></pre> <p>//Column name with link for sorting records</p> <pre><code> &lt;th&gt;&lt;a href='index.php?&lt;?php echo $order ?&gt;&amp;orderBy=articleTitle&lt;?php echo $page ?&gt;' &gt;Article Title&lt;/a&gt;&lt;/th&gt; &lt;th&gt;&lt;a href='index.php?&lt;?php echo $order ?&gt;&amp;orderBy=articleSubTitle&lt;?php echo $page ?&gt;' &gt;Article SubTitle&lt;/a&gt;&lt;/th&gt; &lt;/tr&gt; &lt;?php $perpage = 2; if (isset($_GET["page"])) { $page = intval($_GET["page"]); } else { $page = 1; } $calc = $perpage * $page; $start = $calc - $perpage; $where = ""; if (isset($_GET['orderBy'])) { $order = "ASC"; if (isset($_GET['order']) &amp;&amp; $_GET['order'] == "ASC") { $order = "DESC"; } $where.=" ORDER BY " . $_GET['orderBy'] . " " . $order; } $result = mysql_query("SELECT * FROM xp_article $where Limit $start, $perpage"); $i = 0; if (isset($_GET['order']) &amp;&amp; $_GET['order'] == "ASC") { asort($result); } while ($row = mysql_fetch_array($result)) { echo "&lt;tr&gt;"; echo "&lt;td style='text-align:center'&gt;" . $row['articleTitle'] . "&lt;/td&gt;"; echo "&lt;td style='text-align:center'&gt;" . $row['articleSubTitle'] . "&lt;/td&gt;"; echo "&lt;/tr&gt;"; } ?&gt; </code></pre> <p>//Pagination code</p> <pre><code> &lt;tr&gt; &lt;th colspan="3" class="paging" style="text-align: center"&gt; &lt;?php if (isset($page)) { $result1 = mysql_query("SELECT Count(*) As Total FROM xp_article"); $rows = mysql_num_rows($result1); if ($rows) { $rs = mysql_fetch_array($result1); $total = $rs["Total"]; } $totalPages = ceil($total / $perpage); if ($page &lt;= 1) { echo "&lt;span&gt;Prev&lt;/span&gt;"; } else { $j = $page - 1; echo "&lt;span&gt;&lt;a href='index.php?page=$j'&gt;&lt; Prev&lt;/a&gt;&lt;/span&gt;"; } for ($i = 1; $i &lt;= $totalPages; $i++) { if ($i &lt;&gt; $page) { echo "&amp;nbsp;&amp;nbsp;&lt;span&gt;&lt;a href='index.php?page=$i' &gt;$i&lt;/a&gt;&lt;/span&gt;"; } else { echo "&amp;nbsp;&amp;nbsp;&lt;span&gt;$i&lt;/span&gt;"; } } if ($page == $totalPages) { echo "&amp;nbsp;&amp;nbsp;&lt;span&gt;Next &gt;&lt;/span&gt;"; } else { $j = $page + 1; echo "&amp;nbsp;&amp;nbsp;&lt;span&gt;&lt;a href='index.php?page=$j'&gt;Next&lt;/a&gt;&lt;/span&gt;"; } } ?&gt; &lt;/th&gt; &lt;/tr&gt; &lt;/table&gt; </code></pre> <p>Can anyone tell me what I am missing.... :)</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USYogesh Pingle
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POSorting by column name is not working in plain php on listing page
      1. This table or related slice is empty.
      1. VTUpMod
    1. CO" ORDER BY " . $_GET['orderBy'] . " " . $order; is a bad practise. You will get SQL injection.
      singulars
      1. POSorting by column name is not working in plain php on listing page
      1. USTechie
    2. COYour code is **wide open** to SQL injection attacks, and you **will be hacked** if you haven't been already. Learn to use prepared/parameterized queries with PDO or similar. In addition, escape all variable data when outputting it for HTML with `htmlspecialchars()`. Also, don't build your URLs by hand! Use `http_build_query()`. Finally, don't align stuff with `&nbsp;`. Use CSS.
      singulars
      1. POSorting by column name is not working in plain php on listing page
      1. USBrad
    3. CO@Brad thanks but can you suggest any other way to do this...
      singulars
      1. POSorting by column name is not working in plain php on listing page
      1. USYogesh Pingle
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload