Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>The problem you have here is a strategy pattern problem. And you've implemented a (non-standard) strategy pattern, with a pretty clever implementation. I worry that it is too clever. That cleverness makes what the code is doing a lot less obvious to the uninitiated.</p> <p>Offhand, I'd favor not bothering. I often write controllers as very thin adapters over domain objects/services. Therefore, I'm willing to take a pragmatic approach to design perfection in the controller. In deciding between slight design problems and obvious code, always choose obvious code. </p> <p>If you have thicker controllers, or some other reason to be really concerned about this problem here, you might consider a more traditional strategy pattern, perhaps aided by an abstract factory that provides different strategy implementations based on authentication state. This meets your design objectives, and will be more immediately familiar to other programmers (if they know design patterns).</p> <p>All that being said, I don't think keeping your clever solution will hurt anything that much. I'd be tempted to change the name; Deny seems like a weird verb there to me. Perhaps <code>AnonymousUsersOnly</code>, that would be a little more communicative to future programmers.</p>
    singulars
    1. This table or related slice is empty.
    1. POSingle Responsibility Principle in MVC controllers. Critique required
      singulars
      1. PTQuestion
    1. PTAnswer
    1. This table or related slice is empty.
    1. UStallseth
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    1. COI totally agree with you that the pragmatic approach is often better than anything clever. But is my solution really that clever? It's essentially 1 line of code. I personally think it's elegant, but clever, no. If we were worried that the uninitiated wouldn't be able to follow what was going on, then why would the whole MVC framework allow us to subclass filters in the first place? Filters are kind of essential learning I would have thought for any would-be MVC programmer. I really like your suggestion regarding naming convention by the way. I'm going to edit my original post to reflect that.
      singulars
      1. PO
      1. USSimonGoldstone
    2. COFollowing on from my previous comment (due to lack of characters left!) virtually every MVC book or training guide has a whole chapter dedicated to the creation of custom filters. And as long as the naming convention is there (e.g. RenderAccountAndProfile_Anonymous or RenderAccountAndProfile_Authorized) then it should be very easy to read what's going on at a glance, wouldn't it?
      singulars
      1. PO
      1. USSimonGoldstone
    3. COSure. I don't think it's a bad solution. The risk is that future maintainers don't understand. They might not understand if your names don't make sense for them (all the time my names make sense to me, and confuse others), or if your method naming convention is not followed, or if these methods get separated spatially in a file. It might also be a problem if you have a case where there is only one or the other, not both. Depending on your context, all those risks might be low (you have a co-located team of MVC ninjas, for example). If you feel like those risks are low, go for it.
      singulars
      1. PO
      1. UStallseth
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload