Databases
StackOverflow2013
Postsdbo
POWhat is the best way to arrange this classes?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POWhat is the best way to arrange this classes?
    primarykey
    data
    text
    <p>I'm doing a simple project to manage data for a tabletop game, but I'm mostly using it to get experience about correct coding.</p> <p>I've just reached a point where I have five classes that are tightly coupled, and I'm not sure whether leaving the whole thing as it is, or refactoring.</p> <p>What I have is basically this:</p> <ul> <li>class <code>ShipTemplate</code>: This class ( that has nothing to do with c++ templates ) has all constant members and contains basic informations about a category of Ships.</li> <li>class <code>TemplateSet</code>: This class contains all ShipTemplates that are currently available to build, and it has a name. It should be stand-alone, since it represents the available technology of each player at any time, so one would be able to save/load different sets at different times.</li> <li>class <code>Ship</code>: This class represents a complete ship, with loadouts, name and other things. It contains a const reference to a ShipTemplate, which the class is not allowed to change, to refer to its basic functionality. It <em>could</em> extend ShipTemplate, but I wanted to keep track of which Ships had a particular underlying ShipTemplate, and it seemed easier doing it like this.</li> <li>class <code>Fleet</code>: This class contains a list of Ships, it has a name and contains other information. It should contain a cost variable equal to the sum of the cost of all Ships in it.</li> <li>class <code>Deployment</code>: This class contains pointers to all the Ships, Fleets, and TemplateSets available to the player. It also needs to keep track of ShipTemplates that are no longer available, but that are still used by already built Ships. It should contain a cost variable equal to the sum of the cost of all Ships available to the Player. It has to manage the transfer of Ships from one Fleet to another. It has to find out which Ships are within a given Fleet, or which Ships have a given ShipTemplate.</li> </ul> <p>Unfortunately every class is pretty interwined with all the others. I thought about different approaches, but I'm not sure if even one of them is the correct one.</p> <ul> <li>Use <code>friend</code> statements all over the place, so that if one class modifies something, it can correctly update all the others.</li> <li>Use very long names, like <code>Deployment::modifyShipThrustInFleet</code>, and allow any modification solely through the Deployment class, which will take care of everything.</li> <li>Remove TemplateSets and Fleets and represent them within Deployment, so that it can update correctly cost values/pointers without breaking any "correctness" rule. This too implies that every modification to the system has to pass through Deployment.</li> <li>Insert into lower classes pointers to upper classes, so for example when changing something in a Ship it can automatically update costs of both its Deployment and Fleet.</li> </ul> <p>Is there some other solution I didn't see, or maybe a refactor into more classes that can help me achieve readable, mantainable code?</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USSvalorzen
    plurals
    1. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POWhat is the best way to arrange this classes?
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POWhat is the best way to arrange this classes?
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POWhat is the best way to arrange this classes?
      1. This table or related slice is empty.
      1. VTUpMod
    1. CORight off the bat, I'd say forget friend statements. Anything that breaks encapsulation should be avoided. Have you diagrammed your class relationships? Sometimes, doing that alone can give you insight into the structure and makes clear certain refactorings... Also, I wouldn't describe your classes in terms of what they contain, but in terms of what they DO. This is important because thinking of what they contain may encourage greater coupling.
      singulars
      1. POWhat is the best way to arrange this classes?
      1. USRonaldBarzell
    2. CO@user1161318: friend does not break encapsulation, since you cannot be "friend" of someone if that someone doesn't what it. Before "dropping a language feature", at least complete the analysis.
      singulars
      1. POWhat is the best way to arrange this classes?
      1. USEmilio Garavaglia
    3. COAnything that allows an outside class to peer in on the inner workings of another class breaks encapsulation. Just because it's given a term and status as a language feature does not change what it is. There's plenty of criticism of friend features out there if you don't believe me. At the very least, the friend feature should be the last thing the OP tries, after exhausting every other solution.
      singulars
      1. POWhat is the best way to arrange this classes?
      1. USRonaldBarzell
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload