StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

PORemove fcn for Binary Search Tree
primarykey
Id
13507389
data
AcceptedAnswerId
13508699
AnswerCount
1
ClosedDate
CommentCount
2
CommunityOwnedDate
CreationDate
2012-11-22T07:02:50.917
FavoriteCount
0
LastActivityDate
2012-11-23T08:34:28.477
LastEditDate
2012-11-22T18:52:09.157
LastEditorUserId
1840555
OwnerUserId
1840555
ParentId
0
PostTypeId
1
Score
0
ViewCount
1617
LastEditorDisplayName
text
Body
<p>Does this remove function for a Binary Search Tree look correct? When I try to delete a node, it runs and brings back the switch menu it's called from, but doesn't actually delete it when you reprint the tree. I'm not sure if I have a return out of place, possibly? </p> <p>My question is: Does this remove statement actually remove the item passed, or does it just play around with it in a cruel fashion giving me a headache?</p> <pre><code>void BinarySearchTree::remove(int d) { //Locate the element bool found = false; if(isEmpty()) { cout<<" This Tree is empty! "<<endl; return; } tree_node* curr; tree_node* parent; curr = root; while(curr != NULL) { if(curr->data == d) { found = true; break; } else { parent = curr; if(d>curr->data) curr = curr->right; else curr = curr->left; } } if(!found) { cout<<" Data not found! "<<endl; return; } // 3 cases : // 1. We're removing a leaf node // 2. We're removing a node with a single child // 3. we're removing a node with 2 children // Node with single child // Node with single child if((curr->left == NULL && curr->right != NULL) || (curr->left != NULL && curr->right == NULL)) { if(curr->left == NULL && curr->right != NULL) { if(parent->left == curr) { parent->left = curr->right; delete curr; } else { parent->right = curr->right; delete curr; } } else // left child present, no right child { if(parent->left == curr) { parent->left = curr->left; delete curr; } else { parent->right = curr->left; delete curr; } } return; } //We're looking at a leaf node if( curr->left == NULL && curr->right == NULL) { if(parent->left == curr) { parent->left = NULL; } else { parent->right = NULL; } delete curr; return; } //Node with 2 children // replace node with smallest value in right subtree if (curr->left != NULL && curr->right != NULL) { tree_node* chkr; chkr = curr->right; if((chkr->left == NULL) && (chkr->right == NULL)) { curr = chkr; delete chkr; curr->right = NULL; } else // right child has children { //if the node's right child has a left child // Move all the way down left to locate smallest element if((curr->right)->left != NULL) { tree_node* lcurr; tree_node* lcurrp; lcurrp = curr->right; lcurr = (curr->right)->left; while(lcurr->left != NULL) { lcurrp = lcurr; lcurr = lcurr->left; } curr->data = lcurr->data; delete lcurr; lcurrp->left = NULL; } else { tree_node* tmp; tmp = curr->right; curr->data = tmp->data; curr->right = tmp->right; delete tmp; } } return; } } </code></pre>
Tags
<c++>
Title
Remove fcn for Binary Search Tree
singulars
PostAcceptedAnswerId
1. PO
  singulars
  PostTypePostTypeId
  PTAnswer
PostParentId
1. This table or related slice is empty.
PostTypePostTypeId
1. PTQuestion
UserLastEditorUserId
1. USuser1840555
UserOwnerUserId
1. USuser1840555
plurals
PostLinksPostIdRelatedPostId
1. This table or related slice is empty.
PostLinksRelatedPostIdPostId
1. This table or related slice is empty.
PostsAcceptedAnswerId
1. This table or related slice is empty.
PostsParentIdCreationDate
1. PO
  singulars
  PostTypePostTypeId
  PTAnswer
VotesPostIdCreationDate
1. This table or related slice is empty.
CommentsPostId
1. CO@SaniHuttunen, why do you say so? I don't see any problem in search algorithm.
  singulars
  PostPostId
  PORemove fcn for Binary Search Tree
  UserUserId
  This table or related slice is empty.
2. COHaha... Read this on my phone and only saw the top part of the code. :)
  singulars
  PostPostId
  PORemove fcn for Binary Search Tree
  UserUserId
  USSani Singh Huttunen

Querying!

Guidance

A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.