StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

POnon recursive binary tree insert() method not working
primarykey
Id
13106230
data
AcceptedAnswerId
13106262
AnswerCount
2
ClosedDate
CommentCount
3
CommunityOwnedDate
CreationDate
2012-10-28T03:52:35.363
FavoriteCount
0
LastActivityDate
2012-10-29T00:01:53.590
LastEditDate
2012-10-29T00:01:53.590
LastEditorUserId
1224599
OwnerUserId
1569754
ParentId
0
PostTypeId
1
Score
1
ViewCount
2167
LastEditorDisplayName
text
Body
<p>I have written a binary tree code for inserting elements into it in non-recursive method. The code is not working as intended. Regardless of how many times I debug the code, nothing seems to be wrong but I am getting wrong results. I am hoping you guys can help. Thanks in advance.</p> <pre><code>void insert(int element){ if(root == NULL){ struct elemq *node; node = (struct elemq *)malloc(sizeof(struct elemq)); node->ele = element; node->left = NULL; node->right = NULL; root = node; cout << root->ele << "\n"; } else{ struct elemq *ref; ref = root; while(ref != NULL){ if(element <= ref->ele){ if(ref->left == NULL){ struct elemq *node; node = (struct elemq *)malloc(sizeof(struct elemq )); node->ele = element; node->left = NULL; node->right = NULL; ref->left = node; break; } else{ ref = ref->left; } } else if(element > ref->ele){ if(ref->right == NULL){ struct elemq *node; node = (struct elemq *)malloc(sizeof(struct elemq )); node->ele = element; node->left = NULL; node->right = NULL; ref->right = node; break; } else{ ref = ref->right; } } } } } </code></pre> <p>Every time I try to insert an element, each element is being treated as <code>root</code>, not only the first time. So, every time, the condition <code>if(root == NULL)</code> is <code>true</code>. I declared <code>root</code> as global variable and initialized it to <code>NULL</code> in <code>main()</code>. I came to know this by putting <code>cout <<</code> in the first <code>if()</code> condition. I modified my previous post to this new question.</p>
Tags
<c++><c><data-structures><binary-tree><binary-search-tree>
Title
non recursive binary tree insert() method not working
singulars
PostAcceptedAnswerId
1. PO
  singulars
  PostTypePostTypeId
  PTAnswer
PostParentId
1. This table or related slice is empty.
PostTypePostTypeId
1. PTQuestion
UserLastEditorUserId
1. USctype.h
UserOwnerUserId
1. USJustin Carrey
plurals
PostLinksPostIdRelatedPostId
1. This table or related slice is empty.
PostLinksRelatedPostIdPostId
1. This table or related slice is empty.
PostsAcceptedAnswerId
1. This table or related slice is empty.
PostsParentIdCreationDate
1. PO
  singulars
  PostTypePostTypeId
  PTAnswer
2. PO
  singulars
  PostTypePostTypeId
  PTAnswer
VotesPostIdCreationDate
1. VO
  singulars
  PostPostId
  POnon recursive binary tree insert() method not working
  UserUserId
  This table or related slice is empty.
  VoteTypeVoteTypeId
  VTApproveEditSuggestion
CommentsPostId

Querying!

Guidance

A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.