StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

POHow to approach and optimize code in C
primarykey
Id
13060989
data
AcceptedAnswerId
13061528
AnswerCount
1
ClosedDate
CommentCount
5
CommunityOwnedDate
CreationDate
2012-10-25T03:11:55.700
FavoriteCount
0
LastActivityDate
2012-10-25T04:21:17.647
LastEditDate
2012-10-25T03:35:11.820
LastEditorUserId
712603
OwnerUserId
1645105
ParentId
0
PostTypeId
1
Score
0
ViewCount
216
LastEditorDisplayName
text
Body
<p>I am new to C and very much interested in knowing how to approach any problem which has more than 3 or 4 functions, I always look at the output required and manipulate my code calling functions inside other functions and getting the required output. Below is my logic for finding a students record through his Id first & then Username. This code according to my professor has an excessive logic and is lacking in many ways, if someone could assist me in how should I approach any problem in C or in any other language it would be of great help for me as a beginner and yes I do write pseudo code first.</p> <pre><code>#include <stdio.h> #include <stdlib.h> #include <string.h> typedef struct{ int id; //Assuming student id to be unique int age; char *userName; //Assuming student userName to be unique char *dept; }student; // Alias "student" created for struct student* createstruct(); // All function prototype declared student* createArray(); void addstruct(student* s2); void searchChar(student* s2,int num); void searchInt(student* s2,int num); student* createstruct() // function createStruct() to malloc data of struct student. { student *s; s = (student*)malloc(sizeof(student)); s->userName = (char*)malloc(sizeof(char)*32); s->dept = (char*)malloc(sizeof(char)*32); printf("please enter id "); scanf("%d",&s->id); printf("please enter age "); scanf("%d",&s->age); printf("please enter userName "); scanf("%31s",s->userName); printf("please enter department "); scanf("%31s",s->dept); printf("\n"); return s; } student* createArray() { student *arr; //declaration of arr poiter, type struct student arr = (student*)malloc(sizeof(student)*10); // memory allocated for a size of 10 return arr; } void addstruct(student *s2) // function for adding data to the structures in array { int i,num; student* s1; printf("please enter the number of records to add:"); scanf("%d",&num); printf("\n"); if(num>0 && num<11) { for(i=0;i<num;i++) // if user want to enter 5 records loop will only run 5 times { s1 = createstruct(); s2[i].id = s1->id; // traversing each element of array and filling in struct data s2[i].age = s1->age; s2[i].userName = s1->userName; s2[i].dept= s1->dept; } } else if(num>10) // if user enters more than 10 { for(i=0;i<10;i++) // loop will still run only 10 times { s1 = createstruct(); s2[i].id = s1->id; s2[i].age = s1->age; s2[i].userName = s1->userName; s2[i].dept = s1->dept; } printf("Array is full"); // Array is full after taking 10 records printf("\n"); } searchInt(s2,num); // Calling searchInt() function to search for an integer in records searchChar(s2,num); // Calling searchChar() function to search for a string in records free(s1); free(s2); } void searchChar(student* s2,int num) // function for searching a string in records of structure { char *c; int i; c = (char*)malloc(sizeof(char)*32); printf("please enter userName to search "); scanf("%31s",c); printf("\n"); for (i=0;i<num;i++) //num is the number of struct records entered by user { if ((strcmp(s2[i].userName,c)==0)) //using strcmp for comparing strings { printf("struct variables are %d, %d, %s, %s\n", s2[i].id,s2[i].age,s2[i].userName,s2[i].dept); break; } else if(i == num-1) { printf("nothing in userName matches: <%s>\n",c); break; } } } void searchInt(student* s2,int num) //searchs for an integer and prints the entire structure { int i,z; printf("please enter id to search "); scanf("%d",&z); printf("\n"); for (i=0;i<num;i++) { if (s2[i].id == z) { printf("struct variables are %d, %d, %s, %s\n\n", s2[i].id,s2[i].age,s2[i].userName,s2[i].dept); break; } else if(i == num-1) { printf("nothing in id matches: <%d>\n\n",z); break; } } } int main(void) { student *s2; s2 = createArray(); addstruct(s2); return 0; } </code></pre>
Tags
<c><function><optimization>
Title
How to approach and optimize code in C
singulars
PostAcceptedAnswerId
1. PO
  singulars
  PostTypePostTypeId
  PTAnswer
PostParentId
1. This table or related slice is empty.
PostTypePostTypeId
1. PTQuestion
UserLastEditorUserId
1. USDavid Robinson
UserOwnerUserId
1. USVbp
plurals
PostLinksPostIdRelatedPostId
1. PL
  singulars
  LinkTypeLinkTypeId
  LTLinked
2. PL
  singulars
  LinkTypeLinkTypeId
  LTLinked
PostLinksRelatedPostIdPostId
1. This table or related slice is empty.
PostsAcceptedAnswerId
1. This table or related slice is empty.
PostsParentIdCreationDate
1. PO
  singulars
  PostTypePostTypeId
  PTAnswer
VotesPostIdCreationDate
1. This table or related slice is empty.
CommentsPostId

Querying!

Guidance

A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.