Databases
StackOverflow2013
Postsdbo
POHow to use $_GET path with file_exists and keep it safe?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POHow to use $_GET path with file_exists and keep it safe?
    primarykey
    data
    text
    <p>I have a function to check if a file exists via jQuery which makes a call to a PHP script which I'll use when changing certain images at the click of a button on my index page. </p> <p>jQuery function:</p> <pre><code>function fileExists(path){ $.getJSON("/ajax/fileExists.php",{ path: path }, function (data){ return data.path; }); } </code></pre> <p>fileExists.php:</p> <pre><code>$path=$_SERVER['DOCUMENT_ROOT'].'/packs'.$_GET['path']; if(file_exists($path)){ echo json_encode(TRUE); }else{ echo json_encode(FALSE); } </code></pre> <p>I'm worried about people using this script to list the contents of my server or files which I may not want them to know about so I've used DOCUMENT_ROOT and /packs to try to limit calls to that directory but I think people can simply use ../ within the supplied path to check alternatives.</p> <p>What is the best way to make this safe, ideally limit it to /packs, and are there any other concerns I should worry about?</p> <p>Edit: an example call in javascript/jQuery:</p> <pre><code>if( fileExists('/index.php') ){ alert('Exists'); }else{ alert('Doesn\'t exist'); } </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USdux0r
    plurals
    1. This table or related slice is empty.
    1. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POHow to use $_GET path with file_exists and keep it safe?
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POHow to use $_GET path with file_exists and keep it safe?
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POHow to use $_GET path with file_exists and keep it safe?
      1. This table or related slice is empty.
      1. VTUpMod
    1. COAssuming you control what images are to be displayed, why do you need to check whether they exist?
      singulars
      1. POHow to use $_GET path with file_exists and keep it safe?
      1. USphant0m
    2. COI'm using it within an existing jQuery function which lets the user chose a texture pack from a drop down list, then replaces all existing images with those from said selected texture pack. This function is intended to stop it displaying images which do not exist. You can see it in action on www.texturepacker.net though the code isn't identical as above.
      singulars
      1. POHow to use $_GET path with file_exists and keep it safe?
      1. USdux0r
    3. COSide note: your current function will always return `undefined` because `getJSON` is asynchronous. So your `if` statements won't work either. Look into jQuery Deferreds, it should help you solve that.
      singulars
      1. POHow to use $_GET path with file_exists and keep it safe?
      1. USbfavaretto
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload