Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>Use <code>MySQLCommand</code> instead of <code>MySQLDataAdapter</code>. You are defeating the purpose of using ADONet because still your code is vulnerable with sql injection. Make it parameterized. Below is a modified code from your code. It uses <code>Using-End Using</code> for proper handling of object disposal. </p> <pre><code>Dim ConnectionString As String ="Server=" &amp; FormLogin.ComboBoxServerIP.SelectedItem &amp; ";Port=3306;Uid=trojan;Password=horse;Database=accounting" Dim iQuery As String = "UPDATE customer " &amp; _ "SET accountNumber = @accountNumber, nameLAST = @nameLAST, nameFIRST = @nameFIRST, " &amp; _ " nameSALUTATION = @nameSALUTATION, nameCOMPANY = @nameCOMPANY, addressSTREET = @addressSTREET, " &amp; _ " addressSTREET1 = @addressSTREET1, addressCITY = @addressCITY, addressSTATE = @addressSTATE, " &amp; _ " addressZIPCODE = @addressZIPCODE, phone = @phone, fax = @fax, email = @email " &amp; _ "WHERE accountNumber = @accountNumber" Using dbConn As New MySqlConnection(ConnectionString) Using dbComm As New MySQLCommand() With dbComm .Connection = dbConn .CommandType = CommandType.Text .CommandText = iQuery .Parameters.AddWithValue("@accountNumber", TextBoxAccount.Text ) .Parameters.AddWithValue("@nameLAST", TextBoxLastName.Text) .Parameters.AddWithValue("@nameFIRST", TextBoxFirstName.Text) .Parameters.AddWithValue("@nameSALUTATION", ComboBoxSalutation.SelectedItem) .Parameters.AddWithValue("@nameCOMPANY", TextBoxCompanyName.Text) .Parameters.AddWithValue("@addressSTREET", TextBoxAddress1.Text) .Parameters.AddWithValue("@addressSTREET1", TextBoxAddress2.Text) .Parameters.AddWithValue("@addressCITY", TextBoxCity.Text) .Parameters.AddWithValue("@addressSTATE", ComboBoxState.SelectedItem) .Parameters.AddWithValue("@addressZIPCODE", MaskedTextBoxZip.Text) .Parameters.AddWithValue("@phone", MaskedTextBoxPhone.Text) .Parameters.AddWithValue("@fax", MaskedTextBoxFax.Text) .Parameters.AddWithValue("@email", TextBoxEmail.Text) End With Try dbConn.Open dbComm.ExecuteNonQuery() MessageBox.Show("Customer account SUCCESSFULLY updated!") Call lockForm() Catch( ex as MySQLException) MessageBox.Show("A DATABASE ERROR HAS OCCURED" &amp; vbCrLf &amp; vbCrLf &amp; ex.Message &amp; vbCrLf &amp; _ vbCrLf + "Please report this to the IT/Systems Helpdesk at Ext 131.") Finally dbConn.Close() End Try End Using End Using </code></pre>
    singulars
    1. This table or related slice is empty.
    1. POWhat's causing my UPDATE statement not to work?
      singulars
      1. PTQuestion
    1. PTAnswer
    1. USJohn Woo
    1. USJohn Woo
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. POWhat's causing my UPDATE statement not to work?
      singulars
      1. PTQuestion
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTAcceptedByOriginator
    1. COJohn, thanks for your response. I tried the code but it didn't work. I got an exception that's saying "A fatal database error has occured" but doesn't provide any details beyond that. Also, you repeated the parameter for accountNumber. VB is throwing an exception that the parameter has already been declared. Also, at the begin of the USING statement, you specify a variable "dmComm" the use "dbComm" at the WITH statement - is this just a typo?
      singulars
      1. PO
      1. USKismet Agbasi
    2. CO@KismetAgbasican you try it again? i just updated the answer. is there any else error that has been generated?
      singulars
      1. PO
      1. USJohn Woo
    3. COIt worked John. VB still didn't like the repeat of the accountNumber parameter so I deleted that line and it worked as a charm. Say, what did you change?
      singulars
      1. PO
      1. USKismet Agbasi
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload