Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>There is nothing <em>hugely</em> wrong with that code; note that <code>using</code> is <em>essentially</em> a no-op on a <code>MemoryStream</code>, since it only has <em>managed</em> resources, and managed resources are the domain of the GC; it is normal for the GC not to worry hugely until it makes <em>sense</em> to collect some memory, so I wouldn't stress too much - or: if there is a problem, it probably isn't this.</p> <p>One observation, though, would be that you can avoid a buffer in the encode step:</p> <pre><code>var s = Encoding.ASCII.GetString(stream.GetBuffer(), 0, (int)stream.Length); </code></pre> <p>and actually, I'd be tempted to use UTF8 by default, not ASCII.</p> <p>A final thought: is your <code>SerializerFactory</code> <em>itself</em> doing something that leaks? For example, are you creating a <code>new XmlSerializer(...)</code> via any of the <em>more complex</em> constructors? The simplest form:</p> <pre><code>new XmlSerializer(typeof(SomeType)); </code></pre> <p>is <em>fine</em> - it internally caches the <em>internal/actual</em> serializer per-type, and re-uses this for each <code>XmlSerializer</code> instance created this way. However, it does <em>not</em> do this caching for the more complex constructor overloads: it creates and loads a new dynamic assembly each time. And assemblies loaded in this way <strong><em>are never unloaded</em></strong> - so yes, <em>that</em> can cause a memory leak. I would be very keen to see how the serializer instances are created, to see if <em>that</em> is the actual problem. Note that such cases are usually very easy to fix by creating your own serializer-cache in the factory:</p> <pre><code>public class SerializerFactory { // hashtable has better threading semantics than dictionary, honest! private static readonly Hashtable cache = new Hashtable(); public static IMessageSerializer Create(Type t) { var found = (IMessageSerializer)cache[t]; if(found != null) return found; lock(cache) { // double-checked found = (IMessageSerializer)cache[t]; if(found != null) return found; var types = new List&lt;Type&gt; { t }; var mapper = new MessageMapper(); mapper.Initialize(types); var serializer = new XmlMessageSerializer(mapper); serializer.Initialize(types); cache[t] = serializer; return serializer; } } } </code></pre>
    singulars
    1. This table or related slice is empty.
    1. POMemoryStream leak
      singulars
      1. PTQuestion
    1. PTAnswer
    1. USMarc Gravell
    1. USMarc Gravell
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. POMemoryStream leak
      singulars
      1. PTQuestion
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTAcceptedByOriginator
    2. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    1. COadded the SerializerFactory as edit. thanks and we'll have a look on this
      singulars
      1. PO
      1. USuser1307017
    2. CO@user1307017 edited to add a serializer-cache to your `Create` method
      singulars
      1. PO
      1. USMarc Gravell
    3. COHOLY CRAP... the modification did all the magic. you were right, we were bombarding our program using the old code without caching anything... like in 100,000 times.. we were dynamically creating assemblies.. now we applied that fix, and everything is perfect. thanks!!!
      singulars
      1. PO
      1. USuser1307017
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload