Databases
StackOverflow2013
Postsdbo
POWhy do I need this line, it is redundant as far as I can see
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POWhy do I need this line, it is redundant as far as I can see
    primarykey
    data
    text
    <p>Below is a section of code that I use for parsing tokens.</p> <p>There is a line indicated with <code>&gt;&gt;&gt;&gt;</code> near the bottom that is no longer required, but if I comment it out, the <code>cmd_parse_value_lookup()</code> function fails. If i leave it in, the code runs properly. Could anyone tell me why, and explain what is happening?</p> <pre><code>void cmd_parse(void) { cmd_parse_value=0; int cmd_parse_counter = 1; char *cmd_parse_pointer; cmd_parse_pointer = strtok(cmd_buffer_in, " "); if (cmd_parse_pointer!=NULL) { cmd_parse_value_lookup(cmd_parse_pointer); } while (cmd_parse_pointer != NULL) { cmd_parse_counter++; cmd_parse_pointer = strtok(NULL, " "); if (cmd_parse_pointer!=NULL) { &gt;&gt;&gt;&gt;cmd_buffer_sprintf_return = sprintf(cmd_buffer_sprintf,"%i: %s\r\n", cmd_parse_counter, cmd_parse_pointer); //WHY DO I NEED THIS LINE cmd_parse_value_lookup(cmd_parse_pointer); } } } void cmd_parse_value_lookup(char *cmd_command) { if (strcmp(cmd_command,"show")==0) { cmd_parse_value |= 1; } else if (strcmp(cmd_command,"get")==0) { cmd_parse_value |= 1; } else if (strcmp(cmd_command,"set")==0) { cmd_parse_value |= 2; } else if (strcmp(cmd_command,"system")==0) { cmd_parse_value |= 4; } } </code></pre> <p>Edit: This is the full code:</p> <pre><code>/** C O M M A N D ************************************************************/ #include "generic.h" #include &lt;stdio.h&gt; #include &lt;string.h&gt; void btm_out_character (char character); void btm_out_string(char *string); void cmd_parse(void); char cmd_buffer_in[81]="\0 "; int cmd_buffer_in_position=0; unsigned long long cmd_parse_value=0; char cmd_buffer_sprintf[81]; int cmd_buffer_sprintf_return; void cmd_parse_value_lookup(char *cmd_command); void cmd_buffer_in_add(int character); void cmd_init(void) { } void cmd_cls(void) { if (dbg_mode==1){btm_out_string("\033[2J\033[1;33;40m\033[H\r\n");} if (dbg_mode==1){btm_out_string("================================================================================");} if (dbg_mode==1){btm_out_string("\033[24;0H================================================================================");} if (dbg_mode==1){btm_out_string("\033[1;36;40m\033[8;66H DEBUG MODE ");} if (dbg_mode==1){btm_out_string("\033[24;7H ***** ******** ********** Engineering Limited, All Rights Reserved ");} if (dbg_mode==1){btm_out_string("\033[10;0H");} } void cmd_prompt(void) { cmd_buffer_in_position = 0; // Clear buffer position cmd_buffer_in[0]=0; // Clear buffer if (dbg_mode==1){btm_out_string("\r\n\033[1;37;40m***:&gt; ");} } void cmd_buffer_in_add(int character) { switch (character) { case 8: if (cmd_buffer_in_position&gt;0) { if (dbg_mode==1){btm_out_string("\b \b");} cmd_buffer_in[(int)cmd_buffer_in_position-1] = (char)character; cmd_buffer_in[(int)cmd_buffer_in_position] = 0; cmd_buffer_in_position--; } else { if (dbg_mode==1){btm_out_character(7);} //BELL alert (too long a string) cmd_buffer_in[0] = 0; cmd_buffer_in_position = 0; } break; case 13: cmd_parse(); cmd_buffer_sprintf_return = sprintf(cmd_buffer_sprintf,"\r\nparse value=%llu\r\n", cmd_parse_value); if (dbg_mode==1){btm_out_string(cmd_buffer_sprintf);} cmd_prompt(); break; default: if (cmd_buffer_in_position&lt;73) { if (dbg_mode==1){btm_out_character((char)character);} //Echo character to host cmd_buffer_in[(int)cmd_buffer_in_position] = (char)character; cmd_buffer_in[(int)cmd_buffer_in_position+1] = 0; cmd_buffer_in_position++; } else { if (dbg_mode==1){btm_out_character(7);} //BELL alert (too long a string) } }//switch }//cmd_buffer_in_add void cmd_parse(void) { cmd_parse_value=0; /* this was code for testing */ //cmd_buffer_sprintf_return = sprintf(cmd_buffer_sprintf,"\r\nClone %s",cmd_buffer_in); //cmd_buffer_sprintf_return = sprintf(cmd_buffer_sprintf,"Returnval='%i''%i''%i'",cmd_buffer_in[(int)0],cmd_buffer_in[(int)1],cmd_buffer_in[(int)2]); //if (dbg_mode==1){btm_out_string(cmd_buffer_sprintf);} int cmd_parse_counter = 1; char *cmd_parse_pointer; cmd_parse_pointer = strtok(cmd_buffer_in, " "); if (cmd_parse_pointer!=NULL) { cmd_parse_value_lookup(cmd_parse_pointer); } while (cmd_parse_pointer != NULL) { cmd_parse_counter++; cmd_parse_pointer = strtok(NULL, " "); if (cmd_parse_pointer!=NULL) { cmd_buffer_sprintf_return = sprintf(cmd_buffer_sprintf,"%i: %s\r\n", cmd_parse_counter, cmd_parse_pointer); //WHY DO I NEED THIS LINE //if (dbg_mode==1){btm_out_string(cmd_buffer_sprintf);} cmd_parse_value_lookup(cmd_parse_pointer); } } } void cmd_parse_value_lookup(char *cmd_command) { if (strcmp(cmd_command,"show")==0) { cmd_parse_value |= 1; } else if (strcmp(cmd_command,"get")==0) { cmd_parse_value |= 1; } else if (strcmp(cmd_command,"set")==0) { cmd_parse_value |= 2; } else if (strcmp(cmd_command,"system")==0) { cmd_parse_value |= 4; } else if (strcmp(cmd_command,"sys")==0) { cmd_parse_value |= 4; } else if (strcmp(cmd_command,"adc")==0) { cmd_parse_value |= 8; } else if (strcmp(cmd_command,"a2d")==0) { cmd_parse_value |= 8; } else if (strcmp(cmd_command,"channel1")==0)// { cmd_parse_value |= 16; } else if (strcmp(cmd_command,"ch1")==0) { cmd_parse_value |= 16; } } </code></pre>
    singulars
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PTQuestion
    1. USGraham
    1. USGraham
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POWhy do I need this line, it is redundant as far as I can see
      1. This table or related slice is empty.
      1. VTDownMod
    2. VO
      singulars
      1. POWhy do I need this line, it is redundant as far as I can see
      1. This table or related slice is empty.
      1. VTUpMod
    1. COTough to tell, as we can't see the declaration of `cmd_buffer_sprintf` or see what it gets set to, but if it points into `cmd_buffer_in` somewhere, it's not surprising that deleting the line changes the results.
      singulars
      1. POWhy do I need this line, it is redundant as far as I can see
      1. USChris Dodd
    2. COI have added the rest of the code if that helps
      singulars
      1. POWhy do I need this line, it is redundant as far as I can see
      1. USGraham
    3. COPlease explain what do you mean by "fails". That term is totally useless when asking a question. We want to know: seg fault, bad return value, ... ? It's like going to a mechanic and saying "my car is making a weird noise, what's wrong with it?" The mechanic wants to know what kind of weird noise.
      singulars
      1. POWhy do I need this line, it is redundant as far as I can see
      1. USMarlon
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload