Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p><code>sizeof(guess)</code> is returning the size of a <code>char *</code> <strong>not</strong> the length of the string <code>guess</code>. Your problem is that you're using <code>sizeof</code> to manage string lengths. C has a function for string length: <a href="http://en.cppreference.com/w/c/string/byte/strlen" rel="nofollow"><code>strlen</code></a>.</p> <p><code>sizeof</code> is used to determine the size of data types and arrays. <code>sizeof</code> only works for strings in one very specific case - I won't go into that here - but even then, always use <code>strlen</code> to work with string lengths. </p> <p>You'll want to decide how many characters you'll allow for your words. This is a property of your game, i.e. words in the game are never more that 11 characters long.</p> <p>So:</p> <pre><code>// define this somewhere, a header, or near top of your file #define MAX_WORD_LENGTH 11 // ... size_t wordlen = strlen(word); size_t guessLen; // MAX_WORD_LENGTH + 1, 1 more for the null-terminator: char *guess = malloc(sizeof(char) * (MAX_WORD_LENGTH + 1)); printf("Enter your guess: "); fgets(guess, MAX_WORD_LENGTH, stdin); guessLen = strlen(guess); </code></pre> <p>Also review the docs for <code>fgets</code> and note that the newline character <strong>is</strong> retained in the input, so you'll need to account for that if you want to compare the two words. One quick fix for this is to only compare up to the length of <code>word</code>, and <strong>not</strong> the length of <code>guess</code>, so: <code>if( strncmp(guess, word, wordLen) == 0)</code>. The problem with this quick fix is that it will pass invalid inputs, i.e. if <code>word</code> is <code>eject</code>, and <code>guess</code> is <code>ejection</code>, the comparison will pass.</p> <p>Finally, there's no reason to allocate memory for a new <code>guess</code> in each iteration of the loop, just use the string that you've already allocated. You could change your function setup to:</p> <pre><code>char guess(char *word, char *jumbledWord) { int exit; size_t wordLen = strlen(word); size_t guessLen; char *guess = malloc(sizeof(char) * (MAX_WORD_LENGTH + 1)); do { printf("Enter your guess: "); // ... </code></pre>
    singulars
    1. This table or related slice is empty.
    1. POWhy is fgets() and strncmp() not working in this C code for string comparison?
      singulars
      1. PTQuestion
    1. PTAnswer
    1. USpb2q
    1. USpb2q
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. POWhy is fgets() and strncmp() not working in this C code for string comparison?
      singulars
      1. PTQuestion
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTAcceptedByOriginator
    1. COI think in this case wordLen is MAX_WORD_LENGTH unless that is a special reserved word? I googled it and found nothing. So that is what I assume you meant.
      singulars
      1. PO
      1. USGeekyOmega
    2. COsorry, `MAX_WORD_LENGTH` is something that **you'll** `#define`. added to the answer. it's a constant that you'll choose, and it will limit all strings in the game to a max size. this way the string lengths will be easier to deal with, and since this is a game, it isn't unreasonable to choose a low upper bound; but it's your choice: 11, 23, 50, ...
      singulars
      1. PO
      1. USpb2q
    3. COThanks for your reply pb2q! I made the suggested changes and still getting the same error. It doesn't seem to care what I enter in. It never registers when the string is the same. I also replace guessLen trying in strncmp() and it doesn't work. I tried strcmp() too.
      singulars
      1. PO
      1. USGeekyOmega
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload