Databases
StackOverflow2013
Postsdbo
POCan't delete and erase object pointer on a vector
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POCan't delete and erase object pointer on a vector
    primarykey
    data
    text
    <p>I need to delete and erase object pointer on a vector. I see this question <a href="https://stackoverflow.com/questions/3733081/should-we-delete-before-or-after-erase-for-an-pointer-in-the-vector">Should we delete before or after erase for an pointer in the vector?</a> but I can't erase after delete object pointer.</p> <p>How to fix it? Here my code.</p> <pre><code>#include &lt;iostream&gt; #include &lt;vector&gt; using namespace std; class Foo { public: class bar { public: Foo &amp;_owner; int _id; bar(Foo &amp;owner,int id) : _id(id), _owner(owner){} void remove() { for(vector&lt;bar*&gt;::iterator it=_owner.vbar.begin();it&lt;_owner.vbar.end();it++) { if((*it)-&gt;_id == _id) { //delete object pointer delete * it; //remove element it = _owner.vbar.erase(it); // error on this line. } } } }; vector&lt;bar*&gt; vbar; Foo() { // add 10 elements for(int i=0;i&lt;10;i++) vbar.push_back(new bar(*this ,i)); // remove element at 3 vbar.at(3)-&gt;remove(); } }; int main(int argc, char *argv[]) { Foo foo; return 0; } </code></pre> <hr> <p><strong><em>[Edited]</em></strong> I fixed this by delete object pointer from outside Bar class(delete on Foo class) by adding no longer use bar id to vector on Foo class like this.</p> <pre><code>#include &lt;iostream&gt; #include &lt;vector&gt; using namespace std; class Foo { public: class bar { public: Foo &amp;_owner; int _id; bar(Foo &amp;owner,int id) : _id(id), _owner(owner) {} void remove() { _owner.removeId = _id; _owner.removeHelper(); } }; vector&lt;bar*&gt; vbar; int removeId; Foo() { removeId = -1; // add 10 elements for(int i=0; i&lt;10; i++) vbar.push_back(new bar(*this ,i)); // remove element at 3 vbar.at(3)-&gt;remove(); } void removeHelper() { for(vector&lt;bar*&gt;::iterator it=vbar.begin(); it&lt;vbar.end(); it++) { if((*it)-&gt;_id == removeId) { //delete object pointer delete * it; //remove element it = vbar.erase(it); break; } } removeId = -1; } }; int main(int argc, char *argv[]) { Foo foo; return 0; } </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USCommunity
    1. USPoundXI
    plurals
    1. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POCan't delete and erase object pointer on a vector
      1. This table or related slice is empty.
      1. VTUpMod
    1. CO`std::shared_ptr` is your friend.
      singulars
      1. POCan't delete and erase object pointer on a vector
      1. USRichard J. Ross III
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload