Databases
StackOverflow2013
Postsdbo
POSimple if() not working as expected
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POSimple if() not working as expected
    primarykey
    data
    text
    <p>I am sure that I am simply overlooking something, and I spent a few days working on this and cant seem to figure it out.</p> <p>after logging in on the previous page I get the username and password,</p> <pre><code>$username = mysql_escape_string($_POST['adminusername']); $password = mysql_escape_string($_POST['adminpassword']); </code></pre> <p>and then I go to the database to pull the username and password from the database,</p> <pre><code>$sql = "SELECT username, password FROM `weaponsadmin`"; $rows = $db-&gt;query($sql); while ($record = $db-&gt;fetch_array($rows)) { </code></pre> <p>now here is the part that is confusing me, if i have the following, no matter what I use for the username or password, it will NOT allow for me to login,</p> <pre><code>if ( ($record[username]==$username) &amp;&amp; ($record[password]==$adminpassword) ){ $_SESSION['loggedin'] = true; $_SESSION['username'] = $adminusername; header( "Location: admin.php" ) ; } else { header( "Location: index.php?login=error" ) ; } </code></pre> <p>however if I use the following, it will allow me to login in if the username is correct, but it allows for me to input anything for password and it works,</p> <pre><code>$adminusername = $record[username]; $adminpassword = $record[password]; if ( ($adminusername==$username) &amp;&amp; ($adminpassword==$adminpassword) ) { $_SESSION['loggedin'] = true; $_SESSION['username'] = $adminusername; header( "Location: admin.php" ) ; } else { header( "Location: index.php?login=error" ) ; } </code></pre> <p>So in summary for some reason the <code>&amp;&amp;</code> part doesn't seem to work correctly and if somebody could help me with the code and let me know where my code could be improved for better security and how to make this work correctly, thanks </p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USChris James Champeau
    plurals
    1. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POSimple if() not working as expected
      1. This table or related slice is empty.
      1. VTApproveEditSuggestion
    1. COArray indexes should be integers or strings, so `$record[username]` should be `$record['username']`. Without the quotes, PHP is trying to find the `username`/`password` constants. Docs: http://php.net/manual/en/language.types.array.php
      singulars
      1. POSimple if() not working as expected
      1. USJasper
    2. CO`$adminpassword==$adminpassword` is always true....
      singulars
      1. POSimple if() not working as expected
      1. USWrikken
    3. CO@Wrikken yup that is the problem, thanks i knew it was something simple
      singulars
      1. POSimple if() not working as expected
      1. USChris James Champeau
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload