Databases
StackOverflow2013
Postsdbo
POParameterize SQL query
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POParameterize SQL query
    primarykey
    data
    text
    <p>Many posts about Parameters in SQL with C# but I am still missing something. I am not getting an error message but no data is inserted. What is missing? I have text boxes named fname, lname, address, city, state and zip. </p> <pre><code> private void enter_button_Click(object sender, EventArgs e) { string first, last, addy, city1, stat, zippy; first = fname.Text; SqlParameter firstparam; firstparam = new SqlParameter(); firstparam.ParameterName = "@first"; firstparam.Value = first; last = lname.Text; SqlParameter lastparam; lastparam = new SqlParameter(); lastparam.ParameterName = "@last"; lastparam.Value = last; addy = address.Text; SqlParameter addressparam; addressparam = new SqlParameter(); addressparam.ParameterName = "@addy"; addressparam.Value = addy; city1 = city.Text; SqlParameter cityparam; cityparam = new SqlParameter(); cityparam.ParameterName = "@city1"; cityparam.Value = city1; stat = state.Text; SqlParameter stateparam; stateparam = new SqlParameter(); stateparam.ParameterName = "@stat"; stateparam.Value = stat; zippy = zip.Text; SqlParameter zipparam; zipparam = new SqlParameter(); zipparam.ParameterName = "@zippy"; zipparam.Value = zippy; try { Validate(fname); Validate(lname); Validate(city); Validate(state); } catch (Exception ex) { throw new Exception(ex.ToString(), ex); } try { exValidate(address); } catch (Exception ex1) { throw new Exception(ex1.ToString(), ex1); } try { numValidate(zip); } catch (Exception ex2) { throw new Exception(ex2.ToString(), ex2); } string connection = "Data Source=TX-MANAGER;Initial Catalog=Contacts;Integrated Security=True"; var sqlstring = string.Format("INSERT INTO Contacts ([First] ,[Last] ,[Address] ,[City] ,[State],[ZIP]) VALUES {0}, {1}, {2}, {3}, {4}, {5})", @first, @last, @addy, @city1, @stat, @zippy); SqlConnection conn = new SqlConnection(connection); SqlCommand comm = new SqlCommand(); comm.CommandText = sqlstring; try { conn.Open(); //SqlTransaction trans = conn.BeginTransaction(); //comm.Transaction = trans; comm.Parameters.Add("@first", SqlDbType.Text); comm.Parameters.Add("@last", SqlDbType.Text); comm.Parameters.Add("@addy", SqlDbType.Text); comm.Parameters.Add("@city1", SqlDbType.Text); comm.Parameters.Add("@stat", SqlDbType.Text); comm.Parameters.Add("@zippy", SqlDbType.SmallInt); } catch (Exception commex) { throw new Exception(commex.ToString(), commex); } conn.Close(); } </code></pre> <p>So I changed to this and still nothing happens.</p> <pre><code> string connection = "Data Source=TX-MANAGER;Initial Catalog=Contacts;Integrated Security=True"; var sqlstring = string.Format("INSERT INTO Contacts ([First] ,[Last] ,[Address] ,[City] ,[State],[ZIP]) VALUES {0}, {1}, {2}, {3}, {4}, {5})", @first, @last, @addy, @city1, @stat, @zippy); SqlConnection conn = new SqlConnection(connection); SqlCommand comm = conn.CreateCommand(); comm.CommandText = sqlstring; try { conn.Open(); //SqlTransaction trans = conn.BeginTransaction(); //comm.Transaction = trans; comm.Parameters.AddWithValue("@first", first); comm.Parameters.AddWithValue("@last", last); comm.Parameters.AddWithValue("@addy", addy); comm.Parameters.AddWithValue("@city1", city1); comm.Parameters.AddWithValue("@stat", stat); comm.Parameters.AddWithValue("@zippy", zippy); comm.ExecuteNonQuery(); </code></pre>
    singulars
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PTQuestion
    1. USmarcmiller2007
    1. USmarcmiller2007
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POParameterize SQL query
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POParameterize SQL query
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POParameterize SQL query
      1. This table or related slice is empty.
      1. VTUpMod
    1. COYour connection will not be closed in case of an exception since you're rethrowing the exception in the catch-clause and the `conn.Close()` is outside of the (not existing) finally-block. Use `using-statement` instead.
      singulars
      1. POParameterize SQL query
      1. USTim Schmelter
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload