Databases
StackOverflow2013
Postsdbo
PODeep Copy Constructor for binary tree
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PODeep Copy Constructor for binary tree
    primarykey
    data
    text
    <p>I am trying to create a deep copy of my binary tree data structure in C++. The problem is the code I am using only seems to be giving me a shallow copy (which seems to cause problems with my deconstructor). </p> <p>the code below is my binary tree copy constructor:</p> <pre><code>BinaryTreeStorage::BinaryTreeStorage(const BinaryTreeStorage &amp;copytree):root(NULL) { root = copytree.root; copyTree(root); } BinaryTreeStorage::node* BinaryTreeStorage::copyTree(node* other) { //if node is empty (at bottom of binary tree) /* This creates a shallow copy which in turn causes a problem with the deconstructor, could not work out how to create a deep copy. */ if (other == NULL) { return NULL; } node* newNode = new node; if (other -&gt;nodeValue == "") { newNode -&gt;nodeValue = ""; } newNode-&gt;left = copyTree(other-&gt;left); newNode-&gt;right = copyTree(other-&gt;right); return newNode; } </code></pre> <p>Any help would be appreciated. Thanks</p> <p>Here is the deconstructor that throws a memory exception (which i believe is because of the shallow copy i do above)</p> <pre><code>BinaryTreeStorage::~BinaryTreeStorage(void) { try { destroy_tree();//Call the destroy tree method delete root;//delete final node } catch(int &amp;error) { cout &lt;&lt; "Error Message : " &lt;&lt; error &lt;&lt; endl; } } void BinaryTreeStorage::destroy_tree() { destroy_tree(root); } void BinaryTreeStorage::destroy_tree(node *leaf) { if(leaf!=NULL) { //Recursively work way to bottom node destroy_tree(leaf-&gt;left); destroy_tree(leaf-&gt;right); //delete node delete leaf; } } </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USLuchian Grigore
    1. USbrian4342
    plurals
    1. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. PODeep Copy Constructor for binary tree
      1. This table or related slice is empty.
      1. VTUpMod
    1. COAssuming nodeValue is string, you need to allocate memory for newNode->nodeValue and copy value from other->nodeValue to newNode->nodeValue
      singulars
      1. PODeep Copy Constructor for binary tree
      1. USrt2800
    2. COand how do i do that? sorry for the noob responce :P
      singulars
      1. PODeep Copy Constructor for binary tree
      1. USbrian4342
    3. CONext to deep copying the root (see answers), you are also not passing the value if it is not an empty string. You probably want `node* newNode = new node(*other);`
      singulars
      1. PODeep Copy Constructor for binary tree
      1. USstefaanv
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload