Databases
StackOverflow2013
Postsdbo
POCannot output correct rows from DB after using an IF statement
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POCannot output correct rows from DB after using an IF statement
    primarykey
    data
    text
    <p>I am trying to create a tsql stored procedure which will output rows based on some parameters. The ultimate aim is to move the rows to another table which is why I have counts - I want to keep track of how many rows I am moving. There are two tables - <code>Notes</code> and <code>ExtraNotes</code>. The <code>ExtraNotes</code> holds overflow info from the first table. </p> <p>I am using the <code>if</code> statement to select the correct rows based on the parameter called <code>NoteType</code> but I don't know how to output the correct select statement within the <code>if</code>. I know the select statement within each <code>if</code> is wrong </p> <pre><code>select * from dbo.Notes left join dbo.ExtraNotes on Notes.NoteID = dbo.ExtraNotes.NoteID where NoteDate &lt;= @Date </code></pre> <p>Could anyone offer some pointers on how I can output the correct rows and possibly restructure this better? </p> <p>The full code is here.</p> <pre><code>alter proc selectrows --external variables @Date datetime, @NoteType varchar(2) as --internal variables --Count variables, before any changes declare @count_rowsBefore int declare @count_Extra_rowsBefore int --Count variables of selected rows to be moved declare @count_SelectedRows int declare @count_Extra_SelectedRows int select @count_rowsBefore = count(*) from dbo.Notes select @count_Extra_SelectedRows = count(*) from dbo.ExtraNotes if(@NoteType= 'B') begin select @count_SelectedRows = count(dbo.Notes.NoteID), @count_Extra_SelectedRows = count(dbo.ExtraNotes.NoteID) from dbo.Notes left join dbo.ExtraNotes on Notes.NoteID = dbo.ExtraNotes.NoteID where NoteDate &lt;= @Date select * from dbo.Notes left join dbo.ExtraNotes on Notes.NoteID = dbo.ExtraNotes.NoteID where NoteDate &lt;= @Date end else if(@NoteType = 'S') begin select @count_SelectedRows = count(dbo.Notes.NoteID), @count_Extra_SelectedRows = count(dbo.ExtraNotes.NoteID) from dbo.Notes left join dbo.ExtraNotes on Notes.NoteID = dbo.ExtraNotes.NoteID where NoteDate &lt;= @Date and NoteType = 'S' select * from dbo.Notes left join dbo.ExtraNotes on Notes.NoteID = dbo.ExtraNotes.NoteID where NoteDate &lt;= @Date end else if (@NoteType = 'M') begin select @count_SelectedRows = count(dbo.Notes.NoteID), @count_Extra_SelectedRows = count(dbo.ExtraNotes.NoteID) from dbo.Notes left join dbo.ExtraNotes on Notes.NoteID = dbo.ExtraNotes.NoteID where NoteDate &lt;= @Date and NoteType = 'M' select * from dbo.Notes left join dbo.ExtraNotes on Notes.NoteID = dbo.ExtraNotes.NoteID where NoteDate &lt;= @Date end else begin raiserror('Please enter a valid Note Read Type= M, S or B',16,1) end Print 'Total Number of rows: ' + cast(@count_rowsBefore as varchar(10)) Print 'Total Number of "Extra" rows: ' + cast(@count_Extra_RowsBefore as varchar(10)) Print '-----------------------------------------------' Print 'Total Number of rows to Move: ' + cast(@count_SelectedRows as varchar(10)) Print 'Total Number of "Extra" Rows to Move: ' + cast(@count_Extra_SelectedRows as varchar(10)) </code></pre> <p><a href="http://i2.photobucket.com/albums/y19/_karma_/code/ouput.png" rel="nofollow">Output screenshot</a> </p>
    singulars
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PTQuestion
    1. USTony
    1. USkarmaplus
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COI feel like using a function that returns a table would serve you better than a stored procedure here. Checkout table-valued functions: http://msdn.microsoft.com/en-us/library/ms191165.aspx
      singulars
      1. POCannot output correct rows from DB after using an IF statement
      1. USZugwalt
    2. COIt is unclear what you are trying to do here, what's wrong with what you already have, and what you are asking us to do?
      singulars
      1. POCannot output correct rows from DB after using an IF statement
      1. USRBarryYoung
    3. COWhen I run this with the parameter of M for example I get rows back with Notetype M and S which is wrong.
      singulars
      1. POCannot output correct rows from DB after using an IF statement
      1. USkarmaplus
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload