StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

POOverride Model::save() or Implement Before/After Events? How Do I Fatten my Cake Models?
text
Body
copied!<p>I find my edit actions in CakePHP controllers get messy pretty quickly, and I'd like to pull most of that crap into the Model. Let me give you a scenario.</p> <p>I have an users/edit action in my Users controller. I want to let users reset a password (or not reset the password) in my form. If they provide a new password then I pass the three password fields into save() using the fields list parameter of save(). If they don't provide those fields I don't want to pass those fields in using the fields list. </p> <p>The code to check these fields is currently in my controller, what would be a good way to move this into the model?</p> <p>Here's what my controller's edit action looks like:</p> <pre><code>function edit($id = null) { if ($this->Session->check('Auth.User') && $this->Session->read('Auth.User.id') == $id) { if (!$id && empty($this->data)) { $this->Session->setFlash('Invalid Account','default',array('class'=>'flash_error')); $this->redirect(array('controller'=>'directories', 'action' => 'index')); } if (!empty($this->data)) { // take out the following and an error occurs in parentNode() $this->data['User']['group_id'] = 2; if (empty($this->data['User']['old_password'])) { //TODO: pass in a field list for every publicly available save() call. //dont update the password fields if they aren't passing in the old password if ($this->User->save($this->data,true,array('first_name', 'last_name', 'email', 'username'))) { $this->Session->setFlash('Your changes have been saved','default',array('class'=>'flash_ok')); $this->redirect(array('controller'=>'directories','action'=>'index')); } else { $this->Session->setFlash('Your changes could not be saved. Please, try again.','default',array('class'=>'flash_error')); } } else { //update the passwords if ($this->User->save($this->data,true,array('first_name', 'last_name', 'email', 'username', 'password', 'password_confirm', 'old_password'))) { $this->Session->setFlash('Your changes have been saved','default',array('class'=>'flash_ok')); $this->redirect(array('controller'=>'directories','action'=>'index')); } else { $this->Session->setFlash('Your changes could not be saved. Please, try again.','default',array('class'=>'flash_error')); } } } if (empty($this->data)) { $this->data = $this->User->read(array( 'first_name', 'last_name', 'email', 'username' ), $id); } $this->set('user_id',$id); $this->set('current_subscription', $this->User->Subscription->currentSubscription($id)); } else { //redirect to not authorized $this->Session->setFlash('Invalid Account','default',array('class'=>'flash_error')); $this->redirect(array('controller'=>'directories', 'action' => 'index')); } } </code></pre>

Querying!

Guidance

An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload