StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

PO
text
Body
copied!<p>How about splitting the function definitions onto their own lines? I've also added parenthesis to make the function calls clearer (to me). </p> <pre><code>work = () -> async.each( config.targets, (target, callback) -> async.eachLimit( sitemaps, config.concurrency.sitemaps, (sitemap, callback) -> async.eachLimit( sitemap, config.concurrency.urls, (url, callback) -> async.eachSeries( config.requests, (req, callback) -> doRequest( target, sitemap, url, req, callback) , callback) , callback) , callback) , (err) -> console.log "All done" ) </code></pre> <p>EDIT</p> <p>In theory one or more of the inner loops could be broken out as named functions. For example:</p> <pre><code>foo1 = (sitemap, callback) -> async.eachLimit( sitemap, config.concurrency.urls, (url, callback) -> async.eachSeries( config.requests, (req, callback) -> doRequest( target, sitemap, url, req, callback) , callback) , callback) work1 = () -> async.each( config.targets, (target, callback) -> async.eachLimit( sitemaps, config.concurrency.sitemaps, foo1 , callback) , (err) -> console.log "All done" ) # error - target is not defined in doRequest(target...) </code></pre> <p>The problem here is that<code>target</code> as set by the <code>work1</code> loop, does not get passed through <code>foo1</code> to <code>doRequest</code>.</p> <p>Looks like <code>async.apply</code> can be used to get around this problem</p> <pre><code>foo2 = (target, sitemap, callback) -> async.eachLimit( sitemap, config.concurrency.urls, (url, callback) -> async.eachSeries( config.requests, (req, callback) -> doRequest( target, sitemap, url, req, callback) , callback) , callback) work2 = () -> async.each( config.targets, (target, callback) -> async.eachLimit( sitemaps, config.concurrency.sitemaps, async.apply(foo2, target) , callback) , (err) -> console.log "All done 2" ) </code></pre> <p>Or carrying this partitioning to its extreme:</p> <pre><code>foo1 = (target, callback) -> async.eachLimit( sitemaps, config.concurrency.sitemaps , async.apply(foo2, target) , callback) foo2 = (target, sitemap, callback) -> async.eachLimit( sitemap, config.concurrency.urls , async.apply(foo3, target, sitemap) , callback) foo3 = (target, sitemap, url, callback) -> async.eachSeries( config.requests , async.apply(doRequest, target, sitemap, url) , callback) work3 = () -> async.each(config.targets, foo1 , (err) -> console.log "All done 3" ) </code></pre> <p>Other binding/partial methods would work</p> <pre><code>foo2.bind(null, target) # Javascript bind _.partial(foo2, target) # lodash, underscore </code></pre>

Querying!

Guidance

An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload