StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

POC linked list why is my list head variable remaining null (new to C)
text
Body
copied!<p>i received great help on my other questions in relation to this link list problem. My current problem is now that the head of the list remains null so i cannot actually link any nodes to it or print anything out to the console.</p> <p>The problem is the insert_node function, so when print is called the while loop doesn't execute since head is null. I've got through it through the de bugger and it is definitely null it has the address 0x0.</p> <p>Is this another malloc issue? im not too great on that yet.</p> <p>code:</p> <pre><code> /* * File: main.c * Author: che16 * * Created on 20 November 2013, 08:59 */ #include <stdio.h> #include <stdlib.h> #include <string.h> #include "structure.h" /* * */ node* head = NULL; int main(int argc, char** argv) { int no; printf("enter amount of books \n"); scanf("%d", &no); create_books(no); print_list(head); return (EXIT_SUCCESS); } node* create_books(int no_of_books) { char title[50]; char author[30]; unsigned int number; int i; for (i = 0; i < no_of_books; i++) { node* new_node; new_node = (node *) malloc(sizeof (node)); printf("enter book title \n"); scanf("%s", title); printf("enter author name \n"); scanf("%s", author); printf("enter ISDN number \n"); scanf("%10u", &number); strncpy(new_node->btitle, title, 40); strncpy(new_node->name, author, 40); new_node->isbn = number; new_node->n = NULL; insert_node(head, new_node); } } void insert_node(node* head, node* insert) { printf("insert called \n"); insert->n = NULL; if (head == NULL) { head = insert; } else { node* curr = head; while (curr->n != NULL) { curr = curr->n; } curr->n = insert; } printf("finished called \n"); } void delete_node(node* head, node * node) { } void print_list(node * head) { while (head) { printf("%s: \"%s\" (%u)\n", head->btitle, head->name, head->isbn); head = head->n; } } </code></pre> <p><strong>SOLUTION</strong></p> <pre><code>/* * File: main.c * Author: che16 * * Created on 20 November 2013, 08:59 */ #include <stdio.h> #include <stdlib.h> #include <string.h> #include "structure.h" /* * */ node** head = NULL; int main(int argc, char** argv) { int no; printf("enter amount of books \n"); scanf("%d", &no); create_books(no); print_list(head); return (EXIT_SUCCESS); } node* create_books(int no_of_books) { char title[50]; char author[30]; unsigned int number; int i; for (i = 0; i < no_of_books; i++) { node* new_node; new_node = (node *) malloc(sizeof (node)); printf("enter book title \n"); scanf("%s", title); printf("enter author name \n"); scanf("%s", author); printf("enter ISDN number \n"); scanf("%10u", &number); strncpy(new_node->btitle, title, 40); strncpy(new_node->name, author, 40); new_node->isbn = number; new_node->n = NULL; insert_node(&head, new_node); } } void insert_node(node** head, node* insert) { printf("insert called \n"); insert->n = NULL; if (*head == NULL) { *head = insert; } else { node* curr = *head; while (curr->n != NULL) { curr = curr->n; } curr->n = insert; } printf("finished called \n"); } void delete_node(node* head, node * node) { } void print_list(node * head) { while (head) { printf("%s: \"%s\" (%u)\n", head->btitle, head->name, head->isbn); head = head->n; } } </code></pre>

Querying!

Guidance

An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload