StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

PO
text
Body
copied!<p>The problems is the line <code>myArray[name] = word;</code> you're taking an array index from your input line and then setting the character at that position to low bits of the address of your word... I doubt that's actually what you want to do.</p> <p>There's some other problems with your code, you're leaking the memory from the line <code>word = (char *) malloc(16);</code> because strtok returns a pointer into the string you initially pass it. You don't actually need to malloc anything for the code as written in the question, so you could have:</p> <pre><code>char myArray[3000]; char line[100]; char *word = NULL; </code></pre> <p><code>word</code> needs to be a pointer since it's holding the result of <code>strtok()</code></p> <p>You clearly don't understand pointers, you need to review that before you can understand why your code isn't working the way you expect. </p> <p>If you say what your code is actually meant to be doing I can give you some hints on how to fix it, but at the moment I can't quite tell what the intended result is.</p> <p>EDIT: Did you intend to read in your numbers in hexadecimal? The last argument to <code>strtol()</code> is the base to be used for conversion... you could also just use <code>atoi()</code></p> <p>so your loop could look like:</p> <pre><code>char myArray[3000]; char line[100]; char *word = NULL; while(fgets(line, 100, file)) { printf("%s\n", line); word = strtok(line, " :"); if(word == NULL) continue; name = atoi(word); /* only if you didn't actually want hexadecimal */ word = strtok(NULL, " \n"); if(word == NULL) continue; if(name > 0 && name < 3000) { /* as I said in a comment below */ strncpy(myArray + name, word, 3000 - name); } } </code></pre>

Querying!

Guidance

An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload