StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

PO
text
Body
copied!<p>Well you have only two actions in your code, but much too many conditions. Use a single if-else-statement, and boolean operators in the condition. If that was impossible, you could at least</p> <ul> <li>remove the empty lines to get the full logic on one screen page</li> <li>add some comments on what the branches are doing (and why)</li> <li>avoid early returns</li> </ul> <p>Here's your function simplified:</p> <pre><code>var duration = +new Date() - start.time, isPastHalf = Number(duration) < 250 && Math.abs(delta.x) > 20 || Math.abs(delta.x) > viewport / 2, isFarRight = this.content.getBoundingClientRect().left > viewport / 2, direction = delta.x < 0; if (!isScrolling) { if (isPastHalf) { if (direction) this.close(); else { if (isFarRight && pulled) this.close(); else this.open(); } } else { if (isFarRight) { // Looks like the opposite of `direction`, is it? if (this.isEmpty(delta) || delta.x > 0) this.close(); else this.open(); } else this.close(); } } </code></pre> <p>and shortened:</p> <pre><code>var duration = +new Date() - start.time, isPastHalf = Number(duration) < 250 && Math.abs(delta.x) > 20 || Math.abs(delta.x) > viewport / 2, isFarRight = this.content.getBoundingClientRect().left > viewport / 2, direction = delta.x < 0, undirection = this.isEmpty(delta) || delta.x > 0; if (!isScrolling) { if ( isPastHalf && ! direction && !(isFarRight && pulled) || !isPastHalf && !undirection && isFarRight ) this.open(); else this.close(); } </code></pre>

Querying!

Guidance

An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload