StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

POjava - How many classes is too many? When is it appropriate to add new classes?
text
Body
copied!<p>This is intended as a sort of general question, but I'll give you my specific problem first: </p> <p>I'm writing a GUI for my program at the moment for a program that will take the form of a frame with various widgets (labels, text fields etc.) placed on it. It's initially going to use the <code>javax.swing</code> library, but I'm laving a layer of abstraction between the library and the GUI itself to make it easier to create a web application that does the same thing. </p> <p>I'd like to have one class that represents the layout of the GUI: that is to say, it should contain all the information about where the various labels, buttons etc. are placed on the content pane. At the moment, the implementation I'm considering is the following: </p> <pre><code>class Layout { public MyLabel titleLabel; public myTextField sequenceTextField; [...] public void drawTitleLabel() { titleLabel = new MyLabel("This is the title."); titleLabel.setLocation(wherever); titleLabel.draw(); } public void drawSequenceTextField() { sequenceTextField = new MyTextField(); [...] sequenceTextField.draw(); } [...] public void drawGuiFrame() { drawTitleLabel(); drawSequenceTextField(); [...] } } </code></pre> <p>So I declare each widget on the content pane as a field of the class <code>Layout</code>, and then create methods <code>drawWidgetName</code> that draw each widget. Lastly, I create a method that calls each of the <code>draw...</code> methods in order to draw the whole GUI. </p> <p>This seems wrong, though. The <code>draw...</code> methods feel as if they should be methods of the individual widgets themselves, not of the larg-scale layout of the entire GUI. This suggests that I should create separate classes <code>TitleLabel</code>, <code>SequenceTextField</code> etc., each with a <code>draw</code> method, and then just have a <code>drawGuiFrame</code> method in the <code>Layout</code> class that calls all of these <code>draw</code> methods (I could even create an abstract class that these new classes could extend). </p> <p>There would be a few other immediate advantages to this. Suppose I wanted to incorporate a system of checkboxes as well as my labels and text areas. Then I could declare that as its own class and give it properties <code>isOptionA</code>, <code>isOptionB</code> etc. to record which checkbox was ticked. </p> <p>But I am slightly reluctant to implement the GUI this way, for two reasons. Firstly, creating so many new classes would clutter up the codebase with lots of small <code>.java</code> files. Secondly, these would be very much 'single use' classes: I would never use the code again, since the classes would be designed purely for this particular GUI. </p> <p>So - how many classes is too many? Is it OK to create lots of new classes that are only going to be used once just because you feel they <em>should</em> be classes? As I say, although I welcome advice specific to this particular problem, I'm also looking for more general pointers about when it's appropriate to add new classes. </p>

Querying!

Guidance

An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload