StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

PO
text
Body
copied!<ol> <li>You should not use backquotes inside VALUES part. It's only to quote mysql identifiers (like table, column names). I think if you remove it your problem will be solved</li> <li>You should use quotes (regular ones either ' or ") when you quote string value in VALUES part (but see below, there is a better approach)</li> <li>If you choose #2, then you need to properly escape your values from XML by using mysql_real_escape_string in your case. In fact, this is a breach in security (see SQL injections) if you don't do this. But even if you say this is a temporary script one-time usage etc, you'll probably end up with another error when there is single- or double-quote in your xml data</li> <li>The best approach is using PDO prepare statements, then you don't bother quoting certain datatypes with quotes or not doing this - you bind certain param with its datatype. And remember that mysql_* functions are deprecated today.</li> </ol> <p>So this code works like a charm:</p> <pre><code><?php $Products = simplexml_load_file('xml_all_products.xml'); $config = array('db' => array( 'dbname' => 'test', 'host' => 'localhost:4040', 'username' => 'xx', 'password' => 'xxx' )); $db = new PDO('mysql:dbname='.$config['db']['dbname'].';host='.$config['db']['host'],$config['db']['username'],$config['db']['password']); foreach($Products->Product as $Product) { $ProductID = $Product->ProductID; $Name = $Product->Name; $DropshipPrice = $Product->DropshipPrice; $SRP = $Product->SRP; $Brand = $Product->Brand; $Xline = $Product->Xline; $InStock = $Product->InStock; $Stock = $Product->Stock; $Barcode = $Product->Barcode; $Weight = $Product->Weight; $CategoryID = $Product->CategoryID; $Category = $Product->Category; $SmallImage = $Product->SmallImage; $LargeImage = $Product->LargeImage; $Description = $Product->Description; $ProductsRS = $db->prepare("INSERT INTO test(ProductID, Name, DropshipPrice, SRP, Brand, Xline, InStock, Stock, Barcode, Weight, CategoryID, Category, SmallImage, LargeImage, Description) VALUES(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"); $ProductsRS->execute(array($ProductID, $Name, $DropshipPrice, $SRP, $Brand, $Xline, $InStock, $Stock, $Barcode, $Weight, $CategoryID, $Category, $SmallImage, $LargeImage, $Description)); } </code></pre>

Querying!

Guidance

An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload