StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

POphp url routing
text
Body
copied!<p>Hello i have the following code which i use to build a regex from url. the problem is when i don't pass certain params to the method i get the following error:</p> <pre><code>Warning: preg_match(): Empty regular expression on line 27 </code></pre> <p>This is the code:</p> <pre><code>public function buildRegex($uri, array $params) { // Find {params} in URI if(preg_match_all('/\{(?:[^\}]+)\}/', $uri, $this->matches, PREG_SET_ORDER)) { foreach($this->matches as $isMatch) { // Swap {param} with a placeholder $this->uri = str_replace($isMatch, "%s", $uri); } // Build final Regex $this->finalRegex = '/^' . preg_quote($this->uri, '/') . '$/'; $this->finalRegex = vsprintf($this->finalRegex, $params); return $this->finalRegex; } } </code></pre> <p>when i use like this:</p> <pre><code>$routeCollection->add('index', '/index.php/index/home/{name}', 'SiteName:Controller:Index', 'Home', ['name' => '(\w+)']); </code></pre> <p>it works just fine but when i don't have params and i just pass something like:</p> <pre><code>$routeCollection->add('contact', '/index.php/contact/', 'SiteName:Controller:Contact', 'index'); </code></pre> <p>i get that error. Anyway around to give me a hand fixing this problem because i'm out of ideas.</p> <p>The Entire Code of the class:</p> <pre><code>class RouterCollection { public $routeCollection = []; public function add($name, $pattern, $controller, $action = null, array $params = []) { if(!isset($this->routeCollection[$name])) $this->routeCollection[$name] = [ 'pattern' => $pattern, 'controller' => $controller, 'action' => $action, 'params' => $params, ]; } public function findMatch($url) { foreach($this->routeCollection as $routeMap) { $this->regex = $this->buildRegex($routeMap['pattern'], $routeMap['params']); // Let's test the route. if(preg_match($this->regex, $url)) { return ['controller' => $routeMap['controller'], 'action' => $routeMap['action']]; } else { return ['controller' => $this->routeCollection['404']['controller'], 'action' => $this->routeCollection['404']['action']]; } } } public function buildRegex($uri, array $params) { // Find {params} in URI if(preg_match_all('/\{(?:[^\}]+)\}/', $uri, $this->matches, PREG_SET_ORDER)) { foreach($this->matches as $isMatch) { // Swap {param} with a placeholder $this->uri = str_replace($isMatch, "%s", $uri); } // Build final Regex $this->finalRegex = '/^' . preg_quote($this->uri, '/') . '$/'; $this->finalRegex = vsprintf($this->finalRegex, $params); return $this->finalRegex; } } public function getCollection() { return $this->routeCollection; } } </code></pre>

Querying!

Guidance

An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload