StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

PO
text
Body
copied!<p>You are assigning <code>$username</code> and <code>$password</code> before running the validation. <code>set_rules</code> method just sets the rules for validation. It doesn't run it. They are validated at <code>$this->form_validation->run()</code> method. So just place those assignment statements inside <code>if</code> block.</p> <p>It is better to use <code>trim</code> first in <code>set_rules</code> method. i have used it as first rule. You are already checking <code>callback_usernameTaken</code> in set_rules method so no need to check it again in if statement. <code>usernameTaken</code> is better to be in controller than in model. so moved it there. And finally check out the changes i made to usernameTaken method. I have added <code>$this->form_validation->set_message</code> method call and interchanged <code>true</code> and <code>false</code>.</p> <pre><code>function register() { $this->load->helper(array('form', 'url')); $this->load->library('form_validation'); $this->form_validation->set_rules('username', 'Username', 'trim|required|callback_usernameTaken|min_length[5]|max_length[12]'); $this->form_validation->set_rules('password', 'Password', 'trim|required|md5'); if ( $this->form_validation->run() ){ $username = $this->input->post('username'); $password = $this->input->post('password'); $this->membership->newUser($username, $password); $this->session->set_userdata('status', 'OK'); $this->session->set_userdata('username', $username); redirect('home'); } else { $this->session->set_userdata('status', 'NOT_OK'); $this->load->view('shared/header'); $this->load->view('account/signuptitle'); $this->load->view('account/signupview'); $this->load->view('shared/footer'); } } function usernameTaken($username) { $this->db->select('*')->from ('membership')->where('username', $username); $query = $this->db->get(); if ($query->num_rows > 0) { $this->form_validation->set_message('usernameTaken', 'username taken'); return false; } else{ return true; } } </code></pre> <p>CodeIgniter's form-validation class provides both form validation and data prepping features. <a href="http://ellislab.com/codeigniter/user-guide/libraries/form_validation.html" rel="nofollow">http://ellislab.com/codeigniter/user-guide/libraries/form_validation.html</a> So there is nothing wrong in using <code>md5</code> in <code>set_rules</code> method. It will run <code>md5</code> method and return the encrypted string.</p> <p>And for better encryption use <code>Mcrypt</code> extension: php.net/manual/en/intro.mcrypt.php or <code>crypt</code> function: php.net/manual/en/function.crypt.php.</p>

Querying!

Guidance

An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload