Databases
StackOverflow2013
Postsdbo
POmemory error with heap-sort C++
Body
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POmemory error with heap-sort C++
    text
    copied!<p>So I have written a heap-sort program in C++ which takes in an array of doubles and the size of the array and then sorts it. The program works however when I attempt to pass it arrays larger then 1000 I get "Bus error: 10" I think this has to do with how memory is being allocated, however I can not seem to find a solution. </p> <pre><code> #ifndef _HEAPSORT_ #define _HEAPSORT_ void Heapsort(double arrayToSort[], int sizeOfArray); void Heapsort(double arrayToSort[], int sizeOfArray) { // Building Heap: // ========================== int halfSize = sizeOfArray-1 / 2; for(int i = halfSize; i &gt;= 0; i--){ double temp = arrayToSort[i]; int I1 = i, I2 = i+i; do { if( I2 &lt; sizeOfArray - 1 &amp;&amp; arrayToSort[I2+1] &gt; arrayToSort[I2] ) { I2++; } if( arrayToSort[I2] &gt; temp ){ arrayToSort[I1] = arrayToSort[I2]; I1 = I2; I2 = I1+I1; } else { I2 = sizeOfArray; } } while ( I2 &lt; sizeOfArray ); arrayToSort[I1] = temp; } // Sorting Heap: // ========================= for(int i = sizeOfArray-1; i &gt;= 2; i--){ // i is the number of still competing elements double temp = arrayToSort[i]; arrayToSort[i] = arrayToSort[0]; // store top of the heap int I1 = 0, I2 = 1; do { if((I2+1) &lt; i &amp;&amp; arrayToSort[I2+1] &gt; arrayToSort[I2] ) { I2++; } if(arrayToSort[I2] &gt; temp ){ arrayToSort[I1] = arrayToSort[I2]; I1 = I2; I2 = I1+I1; } else { I2 = i; } } while( I2 &lt; i ); arrayToSort[I1] = temp; } double Temp = arrayToSort[1]; arrayToSort[1] = arrayToSort[0]; arrayToSort[0] = Temp; } #endif /* _HEAPSORT_ */ </code></pre> <p>Any insight into how I can fix this would be greatly appreciated. Here is the code where I allocate the memory.</p> <pre><code>#include &lt;iostream&gt; #include "heapsort.h" #include "rmaset.h" #include "ranmar.h" #include "common.h" using namespace std; int main(void) { const int size = 1000; struct Common block; rmaset(block); double array[size]; for(int i = 0; i &lt; size; i++){ array[i] = ranmar(block); } Heapsort(array,size); return 0; } </code></pre> <p>This just creates a struct which then gets passed to a function which initializes it and then to another function ranmar which populates it with random numbers. I have checked all other functions thoroughly and am sure that the error is coming from the Heapsort function. </p>
 

Querying!

 
Guidance
An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload