StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

POmalloc function is not working properly in C program. the program crashes
text
Body
copied!<p>I am beginner in C and this is my first program using malloc() function. I think there might be some problem in using this function.I wanted to use an array(cyclelength) where a solution for a range of number(user input) will be put. so the array size depends on user so i used malloc(). but the program is crashing. Here is my code:</p> <pre><code>#include<stdio.h> #include<stdlib.h> int main() { int x,y,num,count,p,k; for(;;){ printf("enter first integer. must be between 1 and 100000\n"); scanf("%d", &x); printf("enter second integer. must be between 1 and 100000. must not equal the first integer.\n"); scanf("%d", &y); if(x>=1 && x<100000 && y>=1 && y<100000 && x!=y){ break; } else{ printf("try the whole process again\n"); } } if (x<y){ int j; j=y; y=x; x=j; } //making x always greater than y int *cyclelength=malloc(5000*sizeof(int)); if (NULL==cyclelength){ printf("process aborted"); } else{ /*solution part for the range of number. and solution for each number put into cyclelength.*/ num=y; while(num<=x){ p=1; k=num; while(k!=1){ if(k%2==0) k=k/2; else k=3*k+1; p+=1; } count=0; cyclelength[count]=p; num+=1; count+=1; } free(cyclelength); cyclelength=NULL; } int c=0; int max=cyclelength[c]; for(;c<x-y;c+=1){ if(max<cyclelength[c+1]){ max=cyclelength[c+1]; } } printf("%d,%d,%d",x,y,max); return 0; } </code></pre>

Querying!

Guidance

An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload