StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

PODestructor, doesn't delete my object
text
Body
copied!<p>I have big problem- namely my destructor doesn't delete object, in my code which i will paste underneath in main when i call <code>l3.~list();</code> it removes only singly linked list(which is good), but it doesn't remove char* name, even though I am stating in my destructor <code>delete [] name;</code>. Any ideas whats wrong?</p> <p>Here is the code;</p> <pre><code>#include <iostream> #include <cstdlib> #include <string> using namespace std; class list{ struct lista { int num; char* word; lista* next; }; lista* head; char* name; public: list(char* name1){head=NULL;name=new char[strlen(name1)+1];strcpy(name,name1);} char getChar(int key, int index); void setChar(int key, int index, char c); void insert(int number,char* txt); void remove(int number); void print(); list(const list &o); list& operator=(const list &x); ~list(); }; void list::insert(int number,char* txt){ lista* ptr,*tmp; ptr=head; lista* newlista=new lista; newlista->num=number; newlista->next=NULL; newlista->word= new char[strlen(txt)+1]; strcpy(newlista->word,txt); if(head==NULL){ head=newlista; newlista->next=NULL; } else while(ptr!=NULL){ if(strcmp(txt,ptr->word)>=0){ if(ptr->next!=NULL && strcmp(txt,ptr->next->word)<=0) { tmp=ptr->next; ptr->next=newlista; newlista->next=tmp; break; } else if(ptr->next!=NULL && strcmp(txt,ptr->next->word)>0) ptr=ptr->next; else { //next is empty ptr->next=newlista; break; } } else{ //txt mniejszy niz w 1szym elemencie newlista->next=head; head=newlista; break; } } return; } void list::print(){ cout<<name<<";"<<endl; lista *druk; druk=head; while(druk!=NULL){ cout<<"txt: "<<druk->word<<" | "<<"num: "<<druk->num<<endl; druk=druk->next; } cout<<endl; return; } void list::remove(int number){ if(head==NULL) return; if(head->num==number){ lista* ptr=head; head=head->next; delete [] ptr->word; delete ptr; return; } lista* ptr=head; while(ptr->next!=NULL && ptr->next->num!=number) ptr=ptr->next; if(ptr->next==NULL){ cout<<number<<" element not found"<<endl; return; } lista* todelete=ptr->next; ptr->next=todelete->next; delete [] todelete->word; delete todelete; return; } list::list(const list &o) { lista *xtr = o.head; head=NULL;// bez tego nie działa lista *etr=head;// nastawic etr na head? while (xtr) { lista* ntr = new lista; if (!ntr) { cerr << "list::CopyConstructor: Allocation memory failure!"; cerr << endl; break; } ntr->num = xtr->num; ntr->word= new char[strlen(xtr->word)+1]; strcpy(ntr->word,xtr->word); ntr->next = NULL; if (head) etr->next = ntr; else head = ntr; etr = ntr; // keep track of the last element in *this xtr = xtr->next; } name = new char[strlen(o.name)+5]; strcpy(name,o.name); strcat(name,"Copy"); } list& list::operator=(const list &x) { if(this==&x) return *this; lista *etr=head; while(etr) // removing list from this { etr=etr->next; delete head; head=etr; } lista *xtr=x.head; while(xtr) { int copied=xtr->num; lista *ntr= new lista; ntr->word=new char[strlen(xtr->word)+1]; if (!ntr) { cerr << "list::operator=: Allocation memory failure!" << endl; break; } ntr->num=copied; strcpy(ntr->word,xtr->word); ntr->next=NULL; if (!head) head = ntr; else etr->next = ntr; etr = ntr; // keep track of the last element in *this xtr = xtr->next; } char *name=new char[strlen(x.name)+1]; strcpy(name,x.name); return *this; } list::~list() { cout<<"Object with name:"<<name<<" destroyed!"<<endl; delete [] name; lista *dtr=head; while(dtr) // removing lista from this { dtr=dtr->next; delete [] head->word; delete head; head=dtr; } } void f(); void f(){ list o("xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"); o.insert(4,"kazio"); o.insert(100,"312jh31io2"); o.insert(34,"kz31231azio"); o.insert(1020,"123213312jh31io2"); o.insert(213123,"z3213io"); o.insert(1100,"zdrf312jh31io2"); o.print(); } int main(){ list l1("lista1"); l1.insert(5,"Endian"); l1.insert(7,"Endianness"); l1.insert(100,"Hexediting"); l1.insert(34,".mil"); l1.print(); list l2(l1); // usage of CC - the same as list l2=l1; l2.print(); l2.remove(5); l2.print(); l1.print(); list l3("asajnment"); l3=l2=l1; l3.print(); l2.print(); f(); l3.print(); l3.~list(); // here i use destructor on l3 l3.print(); // l3 is being printed with weird name, even though it should be destroyed getchar(); return 0; } </code></pre>

Querying!

Guidance

An individual column

Larger individual text columns get their own page to allow for proper reading.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload